Changeset 1e8b02f5 for src

Timestamp:

Aug 26, 2016, 3:06:08 PM (8 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, ctor, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

5e644d3e

Parents:

f2a4f6c

Message:

removed unnecessary clone statement in validate phase

Location:

src

Files:

• SymTab/Validate.cc (modified) (1 diff)
• SynTree/ReferenceToType.cc (modified) (4 diffs)
• SynTree/Type.h (modified) (1 diff)

src/SymTab/Validate.cc

@@ -531 +531 @@
                         TypeDeclMap::const_iterator base = typedeclNames.find( typeInst->get_name() );
                         assert( base != typedeclNames.end() );
-                        typeInst->set_baseType( base->second->clone() );
+                        typeInst->set_baseType( base->second );
                 } // if
                 return typeInst;

src/SynTree/ReferenceToType.cc

@@ -5 +5 @@
 // file "LICENCE" distributed with Cforall.
 //
-// ReferenceToType.cc -- 
+// ReferenceToType.cc --
 //
 // Author           : Richard C. Bilson
@@ -36 +36 @@
 void ReferenceToType::print( std::ostream &os, int indent ) const {
         using std::endl;
-        
+
         Type::print( os, indent );
         os << "instance of " << typeString() << " " << name << " ";
@@ -128 +128 @@
 }
 
+TypeInstType::~TypeInstType() {
+        // delete baseType; //This is shared and should not be deleted
+}
+
 void TypeInstType::set_baseType( TypeDecl *newValue ) {
         baseType = newValue;
@@ -137 +141 @@
 void TypeInstType::print( std::ostream &os, int indent ) const {
         using std::endl;
-        
+
         Type::print( os, indent );
         os << "instance of " << typeString() << " " << get_name() << " (" << ( isFtype ? "" : "not" ) << " function type) ";

src/SynTree/Type.h

@@ -327 +327 @@
         TypeInstType( const Type::Qualifiers &tq, const std::string &name, bool isFtype );
         TypeInstType( const TypeInstType &other ) : Parent( other ), baseType( other.baseType ), isFtype( other.isFtype ) {}
+        ~TypeInstType();
 
         TypeDecl *get_baseType() const { return baseType; }