Changeset 16ba4897 for src/Common

Timestamp:

Oct 9, 2024, 5:07:59 PM (12 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

0766399

Parents:

1b770e40

Message:

Replaced SemanticErrorException::isEmpty with ...::throwIfNonEmpty. This is how it was used in every context and it saves a bit of text (if not two lines) at every use. I considered putting this function in the header for better inlining, but this should have at least the same preformance as the last version.

Location:

src/Common

Files:

• ErrorObjects.hpp (modified) (1 diff)
• SemanticError.cpp (modified) (1 diff)

src/Common/ErrorObjects.hpp

@@ -41 +41 @@
         void append( SemanticErrorException & other );
         void append( CodeLocation location, const std::string & );
-        bool isEmpty() const;
+        void throwIfNonEmpty();
         void print();
   private:

src/Common/SemanticError.cpp

@@ -88 +88 @@
 }
 
-bool SemanticErrorException::isEmpty() const {
-        return errors.empty();
+void SemanticErrorException::throwIfNonEmpty() {
+        if ( !errors.empty() ) {
+                throw *this;
+        }
 }