Changeset 15f5c5e

Timestamp:

Jun 28, 2018, 2:39:21 PM (6 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, no_list, persistent-indexer, pthread-emulation, qualifiedEnum

Children:

d419d8e

Parents:

e73becf

git-author:

Rob Schluntz <rschlunt@…> (06/28/18 14:36:35)

git-committer:

Rob Schluntz <rschlunt@…> (06/28/18 14:39:21)

Message:

Rename LinkNestedTypes? to HoistTypeDecls?

File:

• src/SymTab/Validate.cc (modified) (4 diffs)

src/SymTab/Validate.cc

@@ -80 +80 @@
 
 namespace SymTab {
-        struct LinkNestedTypes final : public WithDeclsToAdd {
-                void previsit( AggregateDecl * aggr );
-
+        /// hoists declarations that are difficult to hoist while parsing
+        struct HoistTypeDecls final : public WithDeclsToAdd {
                 void previsit( SizeofExpr * );
                 void previsit( AlignofExpr * );
@@ -269 +268 @@
                 PassVisitor<FindSpecialDeclarations> finder;
                 PassVisitor<LabelAddressFixer> labelAddrFixer;
-                PassVisitor<LinkNestedTypes> nestedTypes;
-
-                acceptAll( translationUnit, nestedTypes );
+                PassVisitor<HoistTypeDecls> hoistDecls;
+
+                acceptAll( translationUnit, hoistDecls );
                 EliminateTypedef::eliminateTypedef( translationUnit );
                 ReturnTypeFixer::fix( translationUnit ); // must happen before autogen
@@ -303 +302 @@
 
 
-        void LinkNestedTypes::previsit( AggregateDecl * aggr ) {
-                for ( auto it = aggr->members.begin(); it != aggr->members.end(); ) {
-                        auto current = it++;
-                        Declaration * member = *current;
-                        if ( AggregateDecl * child = dynamic_cast<AggregateDecl *>( member ) ) {
-                                child->parent = aggr;
-                        }
-                }
-        }
-
-        void LinkNestedTypes::handleType( Type * type ) {
+        void HoistTypeDecls::handleType( Type * type ) {
                 // some type declarations are buried in expressions and not easy to hoist during parsing; hoist them here
                 AggregateDecl * aggr = nullptr;
@@ -328 +317 @@
         }
 
-        void LinkNestedTypes::previsit( SizeofExpr * expr ) {
+        void HoistTypeDecls::previsit( SizeofExpr * expr ) {
                 handleType( expr->type );
         }
 
-        void LinkNestedTypes::previsit( AlignofExpr * expr ) {
+        void HoistTypeDecls::previsit( AlignofExpr * expr ) {
                 handleType( expr->type );
         }
 
-        void LinkNestedTypes::previsit( UntypedOffsetofExpr * expr ) {
+        void HoistTypeDecls::previsit( UntypedOffsetofExpr * expr ) {
                 handleType( expr->type );
         }