Changes in src/SynTree/CommaExpr.cc [b4f8808:14388c1]

File:

• src/SynTree/CommaExpr.cc (modified) (2 diffs)

src/SynTree/CommaExpr.cc

@@ -23 +23 @@
 CommaExpr::CommaExpr( Expression *arg1, Expression *arg2 )
                 : Expression(), arg1( arg1 ), arg2( arg2 ) {
+        // xxx - result of a comma expression is never an lvalue, so should set lvalue
+        // to false on all result types. Actually doing this causes some strange things
+        // to happen in later passes (particularly, Specialize, Lvalue, and Box). This needs to be looked into.
         set_result( maybeClone( arg2->get_result() ) );
+        // get_type->set_isLvalue( false );
 }
 
@@ -36 +40 @@
 
 bool CommaExpr::get_lvalue() const {
-        // This is wrong by C, but the current implementation uses it.
-        // (ex: Specialize, Lvalue and Box)
-        return arg2->get_lvalue();
+        // xxx - as above, shouldn't be an lvalue but that information is used anyways.
+        return result->get_lvalue();
 }