Changeset 14388c1

Timestamp:

Aug 13, 2019, 2:03:37 PM (5 years ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

1118b8b

Parents:

7d01cf44

Message:

Most expressions now return a hard-coded lvalue flag.

Location:

src/SynTree

Files:

• ApplicationExpr.cc (modified) (2 diffs)
• CommaExpr.cc (modified) (2 diffs)
• Expression.cc (modified) (9 diffs)
• Expression.h (modified) (12 diffs)
• TupleExpr.cc (modified) (2 diffs)

src/SynTree/ApplicationExpr.cc

@@ -9 +9 @@
 // Author           : Richard C. Bilson
 // Created On       : Mon May 18 07:44:20 2015
-// Last Modified By : Rob Schluntz
-// Last Modified On : Tue Apr 26 12:41:06 2016
-// Update Count     : 4
+// Last Modified By : Andrew Beach
+// Last Modified On : Mon Aug 12 14:28:00 2019
+// Update Count     : 5
 //
 
@@ -76 +76 @@
 }
 
+bool ApplicationExpr::get_lvalue() const {
+        return result->get_lvalue();
+}
+
 void ApplicationExpr::print( std::ostream &os, Indenter indent ) const {
         os << "Application of" << std::endl << indent+1;

src/SynTree/CommaExpr.cc

@@ -9 +9 @@
 // Author           : Richard C. Bilson
 // Created On       : Mon May 18 07:44:20 2015
-// Last Modified By : Rob Schluntz
-// Last Modified On : Mon May 02 15:19:44 2016
-// Update Count     : 1
+// Last Modified By : Andrew Beach
+// Last Modified On : Mon Arg 12 16:11:00 2016
+// Update Count     : 2
 //
 
@@ -39 +39 @@
 }
 
+bool CommaExpr::get_lvalue() const {
+        // xxx - as above, shouldn't be an lvalue but that information is used anyways.
+        return result->get_lvalue();
+}
+
 void CommaExpr::print( std::ostream &os, Indenter indent ) const {
         os << "Comma Expression:" << std::endl;

src/SynTree/Expression.cc

@@ -10 +10 @@
 // Created On       : Mon May 18 07:44:20 2015
 // Last Modified By : Andrew Beach
-// Last Modified On : Wed Aug  7 17:03:00 2019
-// Update Count     : 62
+// Last Modified On : Tue Aug 13 11:31:00 2019
+// Update Count     : 63
 //
 
@@ -64 +64 @@
 
 bool Expression::get_lvalue() const {
-        return result->get_lvalue();
+        assert( !result->get_lvalue() );
+        return false;
 }
 
@@ -138 +139 @@
 }
 
+bool VariableExpr::get_lvalue() const {
+        return result->get_lvalue();
+}
+
 VariableExpr * VariableExpr::functionPointer( FunctionDecl * func ) {
         VariableExpr * funcExpr = new VariableExpr( func );
@@ -269 +274 @@
 CastExpr::~CastExpr() {
         delete arg;
+}
+
+bool CastExpr::get_lvalue() const {
+        return result->get_lvalue();
 }
 
@@ -380 +389 @@
         // don't delete the member declaration, since it points somewhere else in the tree
         delete aggregate;
+}
+
+bool MemberExpr::get_lvalue() const {
+        assert( result->get_lvalue() );
+        return true;
 }
 
@@ -432 +446 @@
 }
 
+bool UntypedExpr::get_lvalue() const {
+        return result->get_lvalue();
+}
 
 void UntypedExpr::print( std::ostream & os, Indenter indent ) const {
@@ -490 +507 @@
         delete arg2;
         delete arg3;
+}
+
+bool ConditionalExpr::get_lvalue() const {
+        return result->get_lvalue();
 }
 
@@ -548 +569 @@
 }
 
+bool ConstructorExpr::get_lvalue() const {
+        return result->get_lvalue();
+}
+
 void ConstructorExpr::print( std::ostream & os, Indenter indent ) const {
         os <<  "Constructor Expression: " << std::endl << indent+1;
@@ -565 +590 @@
 CompoundLiteralExpr::~CompoundLiteralExpr() {
         delete initializer;
+}
+
+bool CompoundLiteralExpr::get_lvalue() const {
+        assert( result->get_lvalue() );
+        return true;
 }
 

src/SynTree/Expression.h

@@ -10 +10 @@
 // Created On       : Mon May 18 07:44:20 2015
 // Last Modified By : Andrew Beach
-// Last Modified On : Wed Aug  7 16:56:00 2019
-// Update Count     : 51
+// Last Modified On : Tue Aug 13 11:30:00 2019
+// Update Count     : 52
 //
 
@@ -71 +71 @@
         const Type * get_result() const { return result; }
         void set_result( Type * newValue ) { result = newValue; }
-        bool get_lvalue() const;
+        virtual bool get_lvalue() const;
 
         TypeSubstitution * get_env() const { return env; }
@@ -99 +99 @@
         virtual ~ApplicationExpr();
 
+        bool get_lvalue() const final;
+
         Expression * get_function() const { return function; }
         void set_function( Expression * newValue ) { function = newValue; }
@@ -121 +123 @@
         UntypedExpr( const UntypedExpr & other );
         virtual ~UntypedExpr();
+
+        bool get_lvalue() const final;
 
         Expression * get_function() const { return function; }
@@ -209 +213 @@
         virtual ~CastExpr();
 
+        bool get_lvalue() const final;
+
         Expression * get_arg() const { return arg; }
         void set_arg( Expression * newValue ) { arg = newValue; }
@@ -292 +298 @@
         virtual ~MemberExpr();
 
+        bool get_lvalue() const final;
+
         DeclarationWithType * get_member() const { return member; }
         void set_member( DeclarationWithType * newValue ) { member = newValue; }
@@ -314 +322 @@
         VariableExpr( const VariableExpr & other );
         virtual ~VariableExpr();
+
+        bool get_lvalue() const final;
 
         DeclarationWithType * get_var() const { return var; }
@@ -501 +511 @@
         virtual ~ConditionalExpr();
 
+        bool get_lvalue() const final;
+
         Expression * get_arg1() const { return arg1; }
         void set_arg1( Expression * newValue ) { arg1 = newValue; }
@@ -525 +537 @@
         virtual ~CommaExpr();
 
+        bool get_lvalue() const final;
+
         Expression * get_arg1() const { return arg1; }
         void set_arg1( Expression * newValue ) { arg1 = newValue; }
@@ -611 +625 @@
         ~ConstructorExpr();
 
+        bool get_lvalue() const final;
+
         Expression * get_callExpr() const { return callExpr; }
         void set_callExpr( Expression * newValue ) { callExpr = newValue; }
@@ -629 +645 @@
         CompoundLiteralExpr( const CompoundLiteralExpr & other );
         virtual ~CompoundLiteralExpr();
+
+        bool get_lvalue() const final;
 
         Initializer * get_initializer() const { return initializer; }
@@ -705 +723 @@
         TupleIndexExpr( const TupleIndexExpr & other );
         virtual ~TupleIndexExpr();
+
+        bool get_lvalue() const final;
 
         Expression * get_tuple() const { return tuple; }

src/SynTree/TupleExpr.cc

@@ -9 +9 @@
 // Author           : Richard C. Bilson
 // Created On       : Mon May 18 07:44:20 2015
-// Last Modified By : Peter A. Buhr
-// Last Modified On : Fri Mar 17 09:42:29 2017
-// Update Count     : 3
+// Last Modified By : Andrew Beach
+// Last Modified On : Mon Aug 12 14:22:00 2019
+// Update Count     : 4
 //
 
@@ -78 +78 @@
 }
 
+bool TupleIndexExpr::get_lvalue() const {
+        assert( result->get_lvalue() );
+        return true;
+}
+
 void TupleIndexExpr::print( std::ostream &os, Indenter indent ) const {
         os << "Tuple Index Expression, with tuple:" << std::endl;