Changeset 13edbac for src/ResolvExpr

Timestamp:

Oct 28, 2022, 5:12:26 PM (3 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, ast-experimental, master

Children:

be5f0a5

Parents:

2856982c (diff), fa2e183 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' of plg.uwaterloo.ca:software/cfa/cfa-cc

Location:

src/ResolvExpr

Files:

• CommonType.cc (modified) (2 diffs)
• ConversionCost.cc (modified) (1 diff)

src/ResolvExpr/CommonType.cc

@@ -991 +991 @@
                                 add_qualifiers( result, type2->qualifiers );
                         } else {
-                                // xxx - does unifying a ref with typed enumInst makes sense?
                                 if (!dynamic_cast<const ast::EnumInstType *>(type2))
                                         result = commonType( type2, ref, tenv, need, have, open, widen, symtab );
@@ -1010 +1009 @@
 
                 void postvisit( const ast::EnumInstType * enumInst ) {
-                        // reuse BasicType/EnumInstType common type by swapping
-                        // xxx - is this already handled by unify?
                         if (!dynamic_cast<const ast::EnumInstType *>(type2))
                                 result = commonType( type2, enumInst, tenv, need, have, open, widen, symtab);

src/ResolvExpr/ConversionCost.cc

@@ -720 +720 @@
                 costCalc( baseType, dst, srcIsLvalue, symtab, env );
         } else {
-                (void)enumInstType;
                 static ast::ptr<ast::BasicType> integer = { new ast::BasicType( ast::BasicType::SignedInt ) };
                 cost = costCalc( integer, dst, srcIsLvalue, symtab, env );