Changeset 11f65b3

Timestamp:

Jan 17, 2024, 4:14:29 PM (11 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

7abc3de

Parents:

5bf685f

Message:

I believe switching isValidOnFuncParam from an allow-list to a forbid-list may have solved the recent nightly builds.

File:

• src/AST/Attribute.cpp (modified) (1 diff)

src/AST/Attribute.cpp

@@ -39 +39 @@
 bool Attribute::isValidOnFuncParam() const {
         // Attributes produce GCC errors when they appear on function
-        // parameters. This is an allow-list, switching to a forbid-list would
-        // have to at least mention:
-        // aligned
+        // parameters. Names on the previous allow-list implementation:
+        // unused, noreturn, __vector_size__
         std::string norm = normalizedName();
-        return norm == "unused" || norm == "noreturn" || norm == "vector_size";
+        return norm != "aligned" && norm != "packed" && norm != "used";
 }