Changeset 10c1770

Timestamp:

Mar 26, 2025, 5:30:13 PM (4 days ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

185cd94

Parents:

30bf6bf

Message:

Refactoring in the resolver. Removed unneeded variable and used the ast::Pass<>::read helper.

File:

• src/ResolvExpr/Resolver.cpp (modified) (2 diffs)

src/ResolvExpr/Resolver.cpp ¶

@@ -703 +703 @@
         } else {
                 if ( !objectDecl->isTypeFixed ) {
-                        auto newDecl = fixObjectType(objectDecl, context);
-                        auto mutDecl = mutate(newDecl);
+                        objectDecl = fixObjectType(objectDecl, context);
 
                         // generate CtorInit wrapper when necessary.
@@ -710 +709 @@
                         // this object in visitor pass, thus disabling CtorInit codegen.
                         // this happens on aggregate members and function parameters.
-                        if ( shouldGenCtorInit( mutDecl ) ) {
+                        if ( shouldGenCtorInit( objectDecl ) ) {
                                 // constructed objects cannot be designated
-                                if ( InitTweak::isDesignated( mutDecl->init ) ) {
-                                        ast::Pass<ResolveDesignators> res( context );
-                                        maybe_accept( mutDecl->init.get(), res );
-                                        if ( !res.core.result ) {
-                                                SemanticError( mutDecl, "Cannot include designations in the initializer for a managed Object.\n"
-                                                                           "If this is really what you want, initialize with @=." );
-                                        }
+                                if ( InitTweak::isDesignated( objectDecl->init )
+                                                && !ast::Pass<ResolveDesignators>::read(
+                                                        objectDecl->init.get(), context ) ) {
+                                        SemanticError( objectDecl, "Cannot include designations in the initializer for a managed Object.\n"
+                                                        "If this is really what you want, initialize with @=." );
                                 }
                                 // constructed objects should not have initializers nested too deeply
-                                if ( ! InitTweak::checkInitDepth( mutDecl ) ) SemanticError( mutDecl, "Managed object's initializer is too deep " );
-
-                                mutDecl->init = InitTweak::genCtorInit( mutDecl->location, mutDecl );
+                                if ( !InitTweak::checkInitDepth( objectDecl ) ) SemanticError( objectDecl, "Managed object's initializer is too deep " );
+
+                                objectDecl = ast::mutate_field( objectDecl, &ast::ObjectDecl::init,
+                                        InitTweak::genCtorInit( objectDecl->location, objectDecl ) );
                         }
-
-                        objectDecl = mutDecl;
                 }
                 currentObject = ast::CurrentObject{ objectDecl->location, objectDecl->get_type() };