Changeset 083cf31 for src/SymTab

Timestamp:

Jan 7, 2016, 11:28:48 AM (10 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, ctor, deferred_resn, demangler, enum, forall-pointer-decay, gc_noraii, jacob/cs343-translation, jenkins-sandbox, master, memory, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

1e9d87b

Parents:

267cb3d (diff), de91427b (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

merge with master

Location:

src/SymTab

Files:

• Indexer.cc (modified) (1 diff)
• Indexer.h (modified) (1 diff)
• Mangler.cc (modified) (5 diffs)
• Mangler.h (modified) (3 diffs)
• Validate.cc (modified) (5 diffs)

src/SymTab/Indexer.cc

@@ -215 +215 @@
                 } else {
                         maybeAccept( sizeofExpr->get_expr(), *this );
+                }
+        }
+
+        void Indexer::visit( AlignofExpr *alignofExpr ) {
+                acceptAllNewScope( alignofExpr->get_results(), *this );
+                if ( alignofExpr->get_isType() ) {
+                        maybeAccept( alignofExpr->get_type(), *this );
+                } else {
+                        maybeAccept( alignofExpr->get_expr(), *this );
                 }
         }

src/SymTab/Indexer.h

@@ -54 +54 @@
                 virtual void visit( ConstantExpr *constantExpr ); 
                 virtual void visit( SizeofExpr *sizeofExpr );
+                virtual void visit( AlignofExpr *alignofExpr );
                 virtual void visit( AttrExpr *attrExpr );
                 virtual void visit( LogicalExpr *logicalExpr );

src/SymTab/Mangler.cc

@@ -30 +30 @@
 
 namespace SymTab {
-        Mangler::Mangler( bool mangleOverridable ) : nextVarNum( 0 ), isTopLevel( true ), mangleOverridable( mangleOverridable ) {
-        }
-
-//Mangler::Mangler( const Mangler & )
-//  : mangleName(), varNums( varNums ), nextVarNum( nextVarNum ), isTopLevel( isTopLevel )
-//{
-//}
+        std::string Mangler::mangleType( Type *ty ) {
+                Mangler mangler( false, true );
+                maybeAccept( ty, mangler );
+                return mangler.get_mangleName();
+        }
+        
+        Mangler::Mangler( bool mangleOverridable, bool typeMode )
+                : nextVarNum( 0 ), isTopLevel( true ), mangleOverridable( mangleOverridable ), typeMode( typeMode ) {}
+                
         Mangler::Mangler( const Mangler &rhs ) : mangleName() {
                 varNums = rhs.varNums;
@@ -42 +44 @@
                 isTopLevel = rhs.isTopLevel;
                 mangleOverridable = rhs.mangleOverridable;
+                typeMode = rhs.typeMode;
         }
 
@@ -152 +155 @@
         void Mangler::mangleRef( ReferenceToType *refType, std::string prefix ) {
                 printQualifiers( refType );
+
                 mangleName << ( refType->get_name().length() + prefix.length() ) << prefix << refType->get_name();
         }
 
+        void Mangler::mangleGenericRef( ReferenceToType *refType, std::string prefix ) {
+                printQualifiers( refType );
+
+                std::ostringstream oldName( mangleName.str() );
+                mangleName.clear();
+
+                mangleName << prefix << refType->get_name();
+
+                std::list< Expression* >& params = refType->get_parameters();
+                if ( ! params.empty() ) {
+                        mangleName << "_";
+                        for ( std::list< Expression* >::const_iterator param = params.begin(); param != params.end(); ++param ) {
+                                TypeExpr *paramType = dynamic_cast< TypeExpr* >( *param );
+                                assert(paramType && "Aggregate parameters should be type expressions");
+                                maybeAccept( paramType->get_type(), *this );
+                        }
+                        mangleName << "_";
+                }
+
+                oldName << mangleName.str().length() << mangleName.str();
+                mangleName.str( oldName.str() );
+        }
+
         void Mangler::visit( StructInstType *aggregateUseType ) {
-                mangleRef( aggregateUseType, "s" );
+                if ( typeMode ) mangleGenericRef( aggregateUseType, "s" );
+                else mangleRef( aggregateUseType, "s" );
         }
 
         void Mangler::visit( UnionInstType *aggregateUseType ) {
-                mangleRef( aggregateUseType, "u" );
+                if ( typeMode ) mangleGenericRef( aggregateUseType, "u" );
+                else mangleRef( aggregateUseType, "u" );
         }
 
@@ -209 +238 @@
 
         void Mangler::printQualifiers( Type *type ) {
+                // skip if not including qualifiers
+                if ( typeMode ) return;
+                
                 if ( ! type->get_forall().empty() ) {
                         std::list< std::string > assertionNames;
@@ -227 +259 @@
                                 varNums[ (*i )->get_name() ] = std::pair< int, int >( nextVarNum++, (int )(*i )->get_kind() );
                                 for ( std::list< DeclarationWithType* >::iterator assert = (*i )->get_assertions().begin(); assert != (*i )->get_assertions().end(); ++assert ) {
-                                        Mangler sub_mangler( mangleOverridable );
+                                        Mangler sub_mangler( mangleOverridable, typeMode );
                                         sub_mangler.nextVarNum = nextVarNum;
                                         sub_mangler.isTopLevel = false;

src/SymTab/Mangler.h

@@ -22 +22 @@
 
 namespace SymTab {
+        /// Mangles names to a unique C identifier
         class Mangler : public Visitor {
           public:
+                /// Mangle syntax tree object; primary interface to clients
                 template< typename SynTreeClass >
-            static std::string mangle( SynTreeClass *decl, bool mangleOverridable = true ); // interface to clients
+            static std::string mangle( SynTreeClass *decl, bool mangleOverridable = true );
+                /// Mangle a type name; secondary interface
+                static std::string mangleType( Type* ty );
 
-///   using Visitor::visit;
                 virtual void visit( ObjectDecl *declaration );
                 virtual void visit( FunctionDecl *declaration );
@@ -45 +48 @@
                 std::string get_mangleName() { return mangleName.str(); }
           private:
-                std::ostringstream mangleName;
+                std::ostringstream mangleName;  ///< Mangled name being constructed
                 typedef std::map< std::string, std::pair< int, int > > VarMapType;
-                VarMapType varNums;
-                int nextVarNum;
-                bool isTopLevel;
-                bool mangleOverridable;
+                VarMapType varNums;             ///< Map of type variables to indices
+                int nextVarNum;                 ///< Next type variable index
+                bool isTopLevel;                ///< Is the Mangler at the top level
+                bool mangleOverridable;         ///< Specially mangle overridable built-in methods
+                bool typeMode;                  ///< Produce a unique mangled name for a type
   
-                Mangler( bool mangleOverridable );
+                Mangler( bool mangleOverridable, bool typeMode );
                 Mangler( const Mangler & );
   
                 void mangleDecl( DeclarationWithType *declaration );
                 void mangleRef( ReferenceToType *refType, std::string prefix );
+                void mangleGenericRef( ReferenceToType *refType, std::string prefix );
   
                 void printQualifiers( Type *type );
@@ -63 +68 @@
         template< typename SynTreeClass >
         std::string Mangler::mangle( SynTreeClass *decl, bool mangleOverridable ) {
-                Mangler mangler( mangleOverridable );
+                Mangler mangler( mangleOverridable, false );
                 maybeAccept( decl, mangler );
                 return mangler.get_mangleName();

src/SymTab/Validate.cc

@@ -10 +10 @@
 // Created On       : Sun May 17 21:50:04 2015
 // Last Modified By : Rob Schluntz
-// Last Modified On : Fri Dec 18 14:32:59 2015
-// Update Count     : 268
+// Last Modified On : Thu Jan 07 11:27:49 2016
+// Update Count     : 269
 //
 
@@ -86 +86 @@
         };
 
-        /// Replaces enum types by int, and function or array types in function parameter and return lists by appropriate pointers
+        /// Replaces enum types by int, and function or array types in function parameter and return lists by appropriate pointers.
         class Pass1 : public Visitor {
                 typedef Visitor Parent;
@@ -161 +161 @@
         };
 
+        class ReturnChecker : public Visitor {
+          public:
+                /// Checks that return statements return nothing if their return type is void
+                /// and return something if the return type is non-void.
+                static void checkFunctionReturns( std::list< Declaration * > & translationUnit );
+
+          private:
+                virtual void visit( FunctionDecl * functionDecl );
+
+                virtual void visit( ReturnStmt * returnStmt );
+
+                std::list< DeclarationWithType * > returnVals;
+        };
+
         class EliminateTypedef : public Mutator {
           public:
-          EliminateTypedef() : scopeLevel( 0 ) {}
-            /// Replaces typedefs by forward declarations
+                EliminateTypedef() : scopeLevel( 0 ) {}
+                /// Replaces typedefs by forward declarations
                 static void eliminateTypedef( std::list< Declaration * > &translationUnit );
           private:
@@ -209 +223 @@
                 acceptAll( translationUnit, pass1 );
                 acceptAll( translationUnit, pass2 );
+                ReturnChecker::checkFunctionReturns( translationUnit );
                 AutogenerateRoutines::autogenerateRoutines( translationUnit );
                 acceptAll( translationUnit, pass3 );
@@ -850 +865 @@
         }
 
+        void ReturnChecker::checkFunctionReturns( std::list< Declaration * > & translationUnit ) {
+                ReturnChecker checker;
+                acceptAll( translationUnit, checker );
+        }
+
+        void ReturnChecker::visit( FunctionDecl * functionDecl ) {
+                std::list< DeclarationWithType * > oldReturnVals = returnVals;
+                returnVals = functionDecl->get_functionType()->get_returnVals();
+                Visitor::visit( functionDecl );
+                returnVals = oldReturnVals;
+        }
+
+        void ReturnChecker::visit( ReturnStmt * returnStmt ) {
+                if ( returnStmt->get_expr() == NULL && returnVals.size() != 0 ) {
+                        throw SemanticError( "Non-void function returns no values: " , returnStmt );
+                } else if ( returnStmt->get_expr() != NULL && returnVals.size() == 0 ) {
+                        throw SemanticError( "void function returns values: " , returnStmt );
+                }
+        }
+
+
         bool isTypedef( Declaration *decl ) {
                 return dynamic_cast< TypedefDecl * >( decl );