Changeset 07033ce

Timestamp:

Jun 14, 2021, 4:03:50 PM (3 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

1f05c83, 6f8c46d, cb5c392

Parents:

a8b0618

Message:

Even more work on removing any possible integer overflow in fast lock test

Files:

• libcfa/src/concurrency/locks.hfa (modified) (3 diffs)
• tests/unified_locking/fast.cfa (modified) (2 diffs)

libcfa/src/concurrency/locks.hfa

@@ -21 +21 @@
 #include "bits/weakso_locks.hfa"
 #include "containers/queueLockFree.hfa"
-
+#include "limits.hfa"
 #include "thread.hfa"
 
@@ -85 +85 @@
         bool tryP(BinaryBenaphore & this) {
                 ssize_t c = this.counter;
+                /* paranoid */ verify( c > MIN );
                 return (c >= 1) && __atomic_compare_exchange_n(&this.counter, &c, c-1, false, __ATOMIC_SEQ_CST, __ATOMIC_RELAXED);
         }
@@ -92 +93 @@
                 ssize_t c = 0;
                 for () {
+                        /* paranoid */ verify( this.counter < MAX );
                         if (__atomic_compare_exchange_n(&this.counter, &c, c+1, false, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST)) {
                                 if (c == 0) return true;

tests/unified_locking/fast.cfa

@@ -22 +22 @@
 uint32_t cs() {
         $thread * me = active_thread();
-        uint32_t value = (uint32_t)me;
+        uint32_t value;
         lock(mo.l);
         {
@@ -28 +28 @@
                 mo.id = me;
                 yield(random(5));
+                value = ((uint32_t)random()) ^ ((uint32_t)me);
                 if(mo.id != me) sout | "Intruder!";
                 mo.sum = tsum + value;