Changeset 06bdba4

Timestamp:

Jun 30, 2022, 11:33:20 AM (2 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, ast-experimental, master, pthread-emulation, qualifiedEnum

Children:

25404c7

Parents:

fc2c57a9 (diff), adf03a6 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' of plg.uwaterloo.ca:software/cfa/cfa-cc

Files:

• doc/theses/thierry_delisle_PhD/thesis/local.bib (modified) (1 diff)
• doc/theses/thierry_delisle_PhD/thesis/text/existing.tex (modified) (6 diffs)
• doc/theses/thierry_delisle_PhD/thesis/text/intro.tex (modified) (3 diffs)
• doc/theses/thierry_delisle_PhD/thesis/text/runtime.tex (modified) (4 diffs)
• libcfa/src/concurrency/locks.hfa (modified) (4 diffs)
• src/AST/Decl.hpp (modified) (1 diff)
• src/AST/Inspect.cpp (modified) (2 diffs)
• src/AST/Inspect.hpp (modified) (2 diffs)
• src/SymTab/Validate.cc (modified) (1 diff)
• src/Validate/LinkReferenceToTypes.cpp (added)
• src/Validate/LinkReferenceToTypes.hpp (added)
• src/Validate/module.mk (modified) (1 diff)
• src/main.cc (modified) (3 diffs)
• tests/enum_tests/structEnum.cfa (modified) (1 diff)

doc/theses/thierry_delisle_PhD/thesis/local.bib

@@ -701 +701 @@
   note = "[Online; accessed 12-April-2022]"
 }
+@misc{wiki:binpak,
+  author = "{Wikipedia contributors}",
+  title = "Bin packing problem --- {W}ikipedia{,} The Free Encyclopedia",
+  year = "2022",
+  url = "https://en.wikipedia.org/wiki/Bin_packing_problem",
+  note = "[Online; accessed 29-June-2022]"
+}
 
 % RMR notes :

doc/theses/thierry_delisle_PhD/thesis/text/existing.tex

@@ -14 +14 @@
 
 \section{Naming Convention}
-Scheduling has been studied by various communities concentrating on different incarnation of the same problems. As a result, there is no standard naming conventions for scheduling that is respected across these communities. This document uses the term \newterm{\Gls{at}} to refer to the abstract objects being scheduled and the term \newterm{\Gls{proc}} to refer to the concrete objects executing these \glspl{at}.
+Scheduling has been studied by various communities concentrating on different incarnation of the same problems. As a result, there are no standard naming conventions for scheduling that is respected across these communities. This document uses the term \newterm{\Gls{at}} to refer to the abstract objects being scheduled and the term \newterm{\Gls{proc}} to refer to the concrete objects executing these \ats.
 
 \section{Static Scheduling}
-\newterm{Static schedulers} require \gls{at} dependencies and costs be explicitly and exhaustively specified prior to scheduling.
+\newterm{Static schedulers} require \ats dependencies and costs be explicitly and exhaustively specified prior to scheduling.
 The scheduler then processes this input ahead of time and produces a \newterm{schedule} the system follows during execution.
 This approach is popular in real-time systems since the need for strong guarantees justifies the cost of determining and supplying this information.
-In general, static schedulers are less relevant to this project because they require input from the programmers that a programming language does not have as part of its concurrency semantic.
+In general, static schedulers are less relevant to this project because they require input from the programmers that the programming language does not have as part of its concurrency semantic.
 Specifying this information explicitly adds a significant burden to the programmer and reduces flexibility.
 For this reason, the \CFA scheduler does not require this information.
 
 \section{Dynamic Scheduling}
-\newterm{Dynamic schedulers} determine \gls{at} dependencies and costs (if at all) during scheduling.
-% Schedulers that support this detection at runtime are referred to as \newterm{Dynamic Schedulers}.
-Hence, unlike static scheduling, \gls{at} dependencies are conditional and detected at runtime. This detection takes the form of observing new \gls{at}(s) in the system and determining dependencies from their behaviour, including suspending or halting a \gls{at} that dynamically detects unfulfilled dependencies. Furthermore, each \gls{at} has the responsibility of adding dependent \glspl{at} back into the system once dependencies are fulfilled. As a consequence, the scheduler often has an incomplete view of the system, seeing only \glspl{at} with no pending dependencies.
+\newterm{Dynamic schedulers} determine \ats dependencies and costs during scheduling, if at all.
+Hence, unlike static scheduling, \ats dependencies are conditional and detected at runtime. This detection takes the form of observing new \ats(s) in the system and determining dependencies from their behaviour, including suspending or halting a \ats that dynamically detects unfulfilled dependencies.
+Furthermore, each \ats has the responsibility of adding dependent \ats back into the system once dependencies are fulfilled.
+As a consequence, the scheduler often has an incomplete view of the system, seeing only \ats with no pending dependencies.
 
 \subsection{Explicitly Informed Dynamic Schedulers}
-While dynamic schedulers may not have an exhaustive list of dependencies for a \gls{at}, some information may be available about each \gls{at}, \eg expected duration, required resources, relative importance, \etc. When available, a scheduler can then use this information to direct the scheduling decisions. \cit{Examples of schedulers with more information} However, most programmers do not determine or even \emph{predict} this information;
-at best, the scheduler has only some imprecision information provided by the programmer, \eg, indicating a \glspl{at} takes approximately 3--7 seconds to complete, rather than exactly 5 seconds. Providing this kind of information is a significant programmer burden especially if the the information does not scale with the number of \glspl{at} and their complexity. For example, providing an exhaustive list of files read by 5 \glspl{at} is an easier requirement then providing an exhaustive list of memory addresses accessed by 10,000 independent \glspl{at}.
-
-Since the goal of this thesis is to provide an \emph{informed} scheduler as a replacement for \CFA's existing \emph{uninformed} scheduler, explicitly informed schedulers are less relevant to this project. Nevertheless, some strategies are worth mentioning.
+While dynamic schedulers may not have an exhaustive list of dependencies for a \ats, some information may be available about each \ats, \eg expected duration, required resources, relative importance, \etc.
+When available, a scheduler can then use this information to direct the scheduling decisions. \cit{Examples of schedulers with more information}
+However, most programmers do not determine or even \emph{predict} this information;
+at best, the scheduler has only some imprecise information provided by the programmer, \eg, indicating a \ats takes approximately 3--7 seconds to complete, rather than exactly 5 seconds.
+Providing this kind of information is a significant programmer burden especially if the information does not scale with the number of \ats and their complexity.
+For example, providing an exhaustive list of files read by 5 \ats is an easier requirement then providing an exhaustive list of memory addresses accessed by 10,000 independent \ats.
+
+Since the goal of this thesis is to provide a scheduler as a replacement for \CFA's existing \emph{uninformed} scheduler, explicitly informed schedulers are less relevant to this project. Nevertheless, some strategies are worth mentioning.
 
 \subsubsection{Priority Scheduling}
-Common information used by schedulers to direct their algorithm is priorities. Each task is given a priority and higher-priority \glspl{at} are preferred to lower-priority ones. The simplest priority scheduling algorithm is to require that every \gls{at} have a distinct pre-established priority and always run the available \gls{at} with the highest priority. Asking programmers to provide an exhaustive set of unique priorities can be prohibitive when the system has a large number of \glspl{at}. It can therefore be desirable for schedulers to support \glspl{at} with identical priorities and/or automatically setting and adjusting priorities for \glspl{at}. The most common adopting some variant on priorities with overlaps and dynamic priority adjustments. For example, Microsoft Windows uses a pair of priorities
+Common information used by schedulers to direct their algorithm is priorities.
+Each \ats is given a priority and higher-priority \ats are preferred to lower-priority ones.
+The simplest priority scheduling algorithm is to require that every \ats have a distinct pre-established priority and always run the available \ats with the highest priority.
+Asking programmers to provide an exhaustive set of unique priorities can be prohibitive when the system has a large number of \ats.
+It can therefore be desirable for schedulers to support \ats with identical priorities and/or automatically setting and adjusting priorities for \ats.
+Most common operating systems use some variant on priorities with overlaps and dynamic priority adjustments.
+For example, Microsoft Windows uses a pair of priorities
 \cit{https://docs.microsoft.com/en-us/windows/win32/procthread/scheduling-priorities,https://docs.microsoft.com/en-us/windows/win32/taskschd/taskschedulerschema-priority-settingstype-element}, one specified by users out of ten possible options and one adjusted by the system.
 
 \subsection{Uninformed and Self-Informed Dynamic Schedulers}
-Several scheduling algorithms do not require programmers to provide additional information on each \gls{at}, and instead make scheduling decisions based solely on internal state and/or information implicitly gathered by the scheduler.
+Several scheduling algorithms do not require programmers to provide additional information on each \ats, and instead make scheduling decisions based solely on internal state and/or information implicitly gathered by the scheduler.
 
 
 \subsubsection{Feedback Scheduling}
-As mentioned, schedulers may also gather information about each \glspl{at} to direct their decisions. This design effectively moves the scheduler into the realm of \newterm{Control Theory}~\cite{wiki:controltheory}. This information gathering does not generally involve programmers, and as such, does not increase programmer burden the same way explicitly provided information may. However, some feedback schedulers do allow programmers to offer additional information on certain \glspl{at}, in order to direct scheduling decisions. The important distinction being whether or not the scheduler can function without this additional information.
+As mentioned, schedulers may also gather information about each \ats to direct their decisions.
+This design effectively moves the scheduler into the realm of \newterm{Control Theory}~\cite{wiki:controltheory}.
+This information gathering does not generally involve programmers, and as such, does not increase programmer burden the same way explicitly provided information may.
+However, some feedback schedulers do allow programmers to offer additional information on certain \ats, in order to direct scheduling decisions.
+The important distinction being whether or not the scheduler can function without this additional information.
 
 
 \section{Work Stealing}\label{existing:workstealing}
-One of the most popular scheduling algorithm in practice (see~\ref{existing:prod}) is work stealing. This idea, introduce by \cite{DBLP:conf/fpca/BurtonS81}, effectively has each worker process its local \glspl{at} first, but allows the possibility for other workers to steal local \glspl{at} if they run out of \glspl{at}. \cite{DBLP:conf/focs/Blumofe94} introduced the more familiar incarnation of this, where each workers has a queue of \glspl{at} and workers without \glspl{at} steal \glspl{at} from random workers. (The Burton and Sleep algorithm had trees of \glspl{at} and steal only among neighbours). Blumofe and Leiserson also prove worst case space and time requirements for well-structured computations.
+One of the most popular scheduling algorithm in practice (see~\ref{existing:prod}) is work stealing.
+This idea, introduce by \cite{DBLP:conf/fpca/BurtonS81}, effectively has each worker process its local \ats first, but allows the possibility for other workers to steal local \ats if they run out of \ats.
+\cite{DBLP:conf/focs/Blumofe94} introduced the more familiar incarnation of this, where each workers has a queue of \ats and workers without \ats steal \ats from random workers\footnote{The Burton and Sleep algorithm had trees of \ats and steal only among neighbours.}.
+Blumofe and Leiserson also prove worst case space and time requirements for well-structured computations.
 
 Many variations of this algorithm have been proposed over the years~\cite{DBLP:journals/ijpp/YangH18}, both optimizations of existing implementations and approaches that account for new metrics.
 
-\paragraph{Granularity} A significant portion of early work-stealing research concentrated on \newterm{Implicit Parallelism}~\cite{wiki:implicitpar}. Since the system is responsible for splitting the work, granularity is a challenge that cannot be left to programmers (as opposed to \newterm{Explicit Parallelism}\cite{wiki:explicitpar} where the burden can be left to programmers). In general, fine granularity is better for load balancing and coarse granularity reduces communication overhead. The best performance generally means finding a middle ground between the two. Several methods can be employed, but I believe these are less relevant for threads, which are generally explicit and more coarse grained.
-
-\paragraph{Task Placement} Since modern computers rely heavily on cache hierarchies\cit{Do I need a citation for this}, migrating \glspl{at} from one core to another can be .  \cite{DBLP:journals/tpds/SquillanteL93}
+\paragraph{Granularity} A significant portion of early work-stealing research concentrated on \newterm{Implicit Parallelism}~\cite{wiki:implicitpar}.
+Since the system is responsible for splitting the work, granularity is a challenge that cannot be left to programmers, as opposed to \newterm{Explicit Parallelism}\cite{wiki:explicitpar} where the burden can be left to programmers.
+In general, fine granularity is better for load balancing and coarse granularity reduces communication overhead.
+The best performance generally means finding a middle ground between the two.
+Several methods can be employed, but I believe these are less relevant for threads, which are generally explicit and more coarse grained.
+
+\paragraph{Task Placement} Since modern computers rely heavily on cache hierarchies\cit{Do I need a citation for this}, migrating \ats from one core to another can be .  \cite{DBLP:journals/tpds/SquillanteL93}
 
 \todo{The survey is not great on this subject}
@@ -61 +83 @@
 
 \subsection{Theoretical Results}
-There is also a large body of research on the theoretical aspects of work stealing. These evaluate, for example, the cost of migration~\cite{DBLP:conf/sigmetrics/SquillanteN91,DBLP:journals/pe/EagerLZ86}, how affinity affects performance~\cite{DBLP:journals/tpds/SquillanteL93,DBLP:journals/mst/AcarBB02,DBLP:journals/ipl/SuksompongLS16} and theoretical models for heterogeneous systems~\cite{DBLP:journals/jpdc/MirchandaneyTS90,DBLP:journals/mst/BenderR02,DBLP:conf/sigmetrics/GastG10}. \cite{DBLP:journals/jacm/BlellochGM99} examines the space bounds of work stealing and \cite{DBLP:journals/siamcomp/BerenbrinkFG03} shows that for under-loaded systems, the scheduler completes its computations in finite time, \ie is \newterm{stable}. Others show that work stealing is applicable to various scheduling contexts~\cite{DBLP:journals/mst/AroraBP01,DBLP:journals/anor/TchiboukdjianGT13,DBLP:conf/isaac/TchiboukdjianGTRB10,DBLP:conf/ppopp/AgrawalLS10,DBLP:conf/spaa/AgrawalFLSSU14}. \cite{DBLP:conf/ipps/ColeR13} also studied how randomized work-stealing affects false sharing among \glspl{at}.
-
-However, as \cite{DBLP:journals/ijpp/YangH18} highlights, it is worth mentioning that this theoretical research has mainly focused on ``fully-strict'' computations, \ie workloads that can be fully represented with a direct acyclic graph. It is unclear how well these distributions represent workloads in real world scenarios.
+There is also a large body of research on the theoretical aspects of work stealing. These evaluate, for example, the cost of migration~\cite{DBLP:conf/sigmetrics/SquillanteN91,DBLP:journals/pe/EagerLZ86}, how affinity affects performance~\cite{DBLP:journals/tpds/SquillanteL93,DBLP:journals/mst/AcarBB02,DBLP:journals/ipl/SuksompongLS16} and theoretical models for heterogeneous systems~\cite{DBLP:journals/jpdc/MirchandaneyTS90,DBLP:journals/mst/BenderR02,DBLP:conf/sigmetrics/GastG10}.
+\cite{DBLP:journals/jacm/BlellochGM99} examines the space bounds of work stealing and \cite{DBLP:journals/siamcomp/BerenbrinkFG03} shows that for under-loaded systems, the scheduler completes its computations in finite time, \ie is \newterm{stable}.
+Others show that work stealing is applicable to various scheduling contexts~\cite{DBLP:journals/mst/AroraBP01,DBLP:journals/anor/TchiboukdjianGT13,DBLP:conf/isaac/TchiboukdjianGTRB10,DBLP:conf/ppopp/AgrawalLS10,DBLP:conf/spaa/AgrawalFLSSU14}.
+\cite{DBLP:conf/ipps/ColeR13} also studied how randomized work-stealing affects false sharing among \ats.
+
+However, as \cite{DBLP:journals/ijpp/YangH18} highlights, it is worth mentioning that this theoretical research has mainly focused on ``fully-strict'' computations, \ie workloads that can be fully represented with a direct acyclic graph.
+It is unclear how well these distributions represent workloads in real world scenarios.
 
 \section{Preemption}
-One last aspect of scheduling is preemption since many schedulers rely on it for some of their guarantees. Preemption is the idea of interrupting \glspl{at} that have been running too long, effectively injecting suspend points into the application. There are multiple techniques to achieve this effect but they all aim to guarantee suspend points in a \gls{at} are never further apart than some fixed duration. While this helps schedulers guarantee that no \glspl{at} unfairly monopolizes a worker, preemption can effectively added to any scheduler. Therefore, the only interesting aspect of preemption for the design of scheduling is whether or not to require it.
+One last aspect of scheduling is preemption since many schedulers rely on it for some of their guarantees.
+Preemption is the idea of interrupting \ats that have been running too long, effectively injecting suspend points into the application.
+There are multiple techniques to achieve this effect but they all aim to guarantee that the suspend points in a \ats are never further apart than some fixed duration.
+While this helps schedulers guarantee that no \ats unfairly monopolizes a worker, preemption can effectively be added to any scheduler.
+Therefore, the only interesting aspect of preemption for the design of scheduling is whether or not to require it.
 
 \section{Production Schedulers}\label{existing:prod}
-This section presents a quick overview of several current schedulers. While these schedulers do not necessarily represent the most recent advances in scheduling, they are what is generally accessible to programmers. As such, I believe these schedulers are at least as relevant as those presented in published work. Schedulers that operate in kernel space and in user space are considered, as both can offer relevant insight for this project. However, real-time schedulers as not considered, as these have constraints that are much stricter than what is needed for this project.
+This section presents a quick overview of several current schedulers.
+While these schedulers do not necessarily represent the most recent advances in scheduling, they are what is generally accessible to programmers.
+As such, I believe these schedulers are at least as relevant as those presented in published work.
+Schedulers that operate in kernel space and in user space are considered, as both can offer relevant insight for this project.
+However, real-time schedulers are not considered, as these have constraints that are much stricter than what is needed for this project.
 
 \subsection{Operating System Schedulers}
-Operating System Schedulers tend to be fairly complex as they generally support some amount of real-time, aim to balance interactive and non-interactive \glspl{at} and support multiple users sharing hardware without requiring these users to cooperate. Here are more details on a few schedulers used in the common operating systems: Linux, FreeBSD, Microsoft Windows and Apple's OS X. The information is less complete for operating systems with closed source.
+Operating System Schedulers tend to be fairly complex as they generally support some amount of real-time, aim to balance interactive and non-interactive \ats and support multiple users sharing hardware without requiring these users to cooperate.
+Here are more details on a few schedulers used in the common operating systems: Linux, FreeBSD, Microsoft Windows and Apple's OS X.
+The information is less complete for operating systems with closed source.
 
 \paragraph{Linux's CFS}
-The default scheduler used by Linux (the Completely Fair Scheduler)~\cite{MAN:linux/cfs,MAN:linux/cfs2} is a feedback scheduler based on CPU time. For each processor, it constructs a Red-Black tree of \glspl{at} waiting to run, ordering them by the amount of CPU time used. The \gls{at} that has used the least CPU time is scheduled. It also supports the concept of \newterm{Nice values}, which are effectively multiplicative factors on the CPU time used. The ordering of \glspl{at} is also affected by a group based notion of fairness, where \glspl{at} belonging to groups having used less CPU time are preferred to \glspl{at} belonging to groups having used more CPU time. Linux achieves load-balancing by regularly monitoring the system state~\cite{MAN:linux/cfs/balancing} and using some heuristic on the load (currently CPU time used in the last millisecond plus a decayed version of the previous time slots~\cite{MAN:linux/cfs/pelt}.).
-
-\cite{DBLP:conf/eurosys/LoziLFGQF16} shows that Linux's CFS also does work stealing to balance the workload of each processors, but the paper argues this aspect can be improved significantly. The issues highlighted stem from Linux's need to support fairness across \glspl{at} \emph{and} across users\footnote{Enforcing fairness across users means that given two users, one with a single \gls{at} and the other with one thousand \glspl{at}, the user with a single \gls{at} does not receive one thousandth of the CPU time.}, increasing the complexity.
-
-Linux also offers a FIFO scheduler, a real-time scheduler, which runs the highest-priority \gls{at}, and a round-robin scheduler, which is an extension of the FIFO-scheduler that adds fixed time slices. \cite{MAN:linux/sched}
+The default scheduler used by Linux, the Completely Fair Scheduler~\cite{MAN:linux/cfs,MAN:linux/cfs2}, is a feedback scheduler based on CPU time.
+For each processor, it constructs a Red-Black tree of \ats waiting to run, ordering them by the amount of CPU time used.
+The \ats that has used the least CPU time is scheduled.
+It also supports the concept of \newterm{Nice values}, which are effectively multiplicative factors on the CPU time used.
+The ordering of \ats is also affected by a group based notion of fairness, where \ats belonging to groups having used less CPU time are preferred to \ats belonging to groups having used more CPU time.
+Linux achieves load-balancing by regularly monitoring the system state~\cite{MAN:linux/cfs/balancing} and using some heuristic on the load, currently CPU time used in the last millisecond plus a decayed version of the previous time slots~\cite{MAN:linux/cfs/pelt}.
+
+\cite{DBLP:conf/eurosys/LoziLFGQF16} shows that Linux's CFS also does work stealing to balance the workload of each processors, but the paper argues this aspect can be improved significantly.
+The issues highlighted stem from Linux's need to support fairness across \ats \emph{and} across users\footnote{Enforcing fairness across users means that given two users, one with a single \ats and the other with one thousand \ats, the user with a single \ats does not receive one thousandth of the CPU time.}, increasing the complexity.
+
+Linux also offers a FIFO scheduler, a real-time scheduler, which runs the highest-priority \ats, and a round-robin scheduler, which is an extension of the FIFO-scheduler that adds fixed time slices. \cite{MAN:linux/sched}
 
 \paragraph{FreeBSD}
-The ULE scheduler used in FreeBSD\cite{DBLP:conf/bsdcon/Roberson03} is a feedback scheduler similar to Linux's CFS. It uses different data structures and heuristics but also schedules according to some combination of CPU time used and niceness values. It also periodically balances the load of the system (according to a different heuristic), but uses a simpler work stealing approach.
+The ULE scheduler used in FreeBSD\cite{DBLP:conf/bsdcon/Roberson03} is a feedback scheduler similar to Linux's CFS.
+It uses different data structures and heuristics but also schedules according to some combination of CPU time used and niceness values.
+It also periodically balances the load of the system (according to a different heuristic), but uses a simpler work stealing approach.
 
 \paragraph{Windows(OS)}
-Microsoft's Operating System's Scheduler~\cite{MAN:windows/scheduler} is a feedback scheduler with priorities. It supports 32 levels of priorities, some of which are reserved for real-time and privileged applications. It schedules \glspl{at} based on the highest priorities (lowest number) and how much CPU time each \gls{at} has used. The scheduler may also temporarily adjust priorities after certain effects like the completion of I/O requests.
+Microsoft's Operating System's Scheduler~\cite{MAN:windows/scheduler} is a feedback scheduler with priorities.
+It supports 32 levels of priorities, some of which are reserved for real-time and privileged applications.
+It schedules \ats based on the highest priorities (lowest number) and how much CPU time each \ats has used.
+The scheduler may also temporarily adjust priorities after certain effects like the completion of I/O requests.
 
 \todo{load balancing}
@@ -102 +149 @@
 
 \subsection{User-Level Schedulers}
-By comparison, user level schedulers tend to be simpler, gathering fewer metrics and avoid complex notions of fairness. Part of the simplicity is due to the fact that all \glspl{at} have the same user, and therefore cooperation is both feasible and probable.
+By comparison, user level schedulers tend to be simpler, gathering fewer metrics and avoid complex notions of fairness. Part of the simplicity is due to the fact that all \ats have the same user, and therefore cooperation is both feasible and probable.
 
 \paragraph{Go}\label{GoSafePoint}
-Go's scheduler uses a randomized work-stealing algorithm that has a global run-queue (\emph{GRQ}) and each processor (\emph{P}) has both a fixed-size run-queue (\emph{LRQ}) and a high-priority next ``chair'' holding a single element~\cite{GITHUB:go,YTUBE:go}. Preemption is present, but only at safe-points,~\cit{https://go.dev/src/runtime/preempt.go} which are inserted detection code at various frequent access boundaries.
+Go's scheduler uses a randomized work-stealing algorithm that has a global run-queue (\emph{GRQ}) and each processor (\emph{P}) has both a fixed-size run-queue (\emph{LRQ}) and a high-priority next ``chair'' holding a single element~\cite{GITHUB:go,YTUBE:go}.
+Preemption is present, but only at safe-points,~\cit{https://go.dev/src/runtime/preempt.go} which are inserted detection code at various frequent access boundaries.
 
 The algorithm is as follows :
@@ -119 +167 @@
 
 \paragraph{Erlang}
-Erlang is a functional language that supports concurrency in the form of processes: threads that share no data. It uses a kind of round-robin scheduler, with a mix of work sharing and stealing to achieve load balancing~\cite{:erlang}, where under-loaded workers steal from other workers, but overloaded workers also push work to other workers. This migration logic is directed by monitoring logic that evaluates the load a few times per seconds.
+Erlang is a functional language that supports concurrency in the form of processes: threads that share no data.
+It uses a kind of round-robin scheduler, with a mix of work sharing and stealing to achieve load balancing~\cite{:erlang}, where under-loaded workers steal from other workers, but overloaded workers also push work to other workers.
+This migration logic is directed by monitoring logic that evaluates the load a few times per seconds.
 
 \paragraph{Intel\textregistered ~Threading Building Blocks}
-\newterm{Thread Building Blocks} (TBB) is Intel's task parallelism \cite{wiki:taskparallel} framework. It runs \newterm{jobs}, which are uninterruptable \glspl{at} that must always run to completion, on a pool of worker threads. TBB's scheduler is a variation of randomized work-stealing that also supports higher-priority graph-like dependencies~\cite{MAN:tbb/scheduler}. It schedules \glspl{at} as follows (where \textit{t} is the last \gls{at} completed):
+\newterm{Thread Building Blocks} (TBB) is Intel's task parallelism \cite{wiki:taskparallel} framework.
+It runs \newterm{jobs}, which are uninterruptable \ats that must always run to completion, on a pool of worker threads.
+TBB's scheduler is a variation of randomized work-stealing that also supports higher-priority graph-like dependencies~\cite{MAN:tbb/scheduler}.
+It schedules \ats as follows (where \textit{t} is the last \ats completed):
 \begin{displayquote}
         \begin{enumerate}
@@ -139 +192 @@
 
 \paragraph{Quasar/Project Loom}
-Java has two projects, Quasar~\cite{MAN:quasar} and Project Loom~\cite{MAN:project-loom}\footnote{It is unclear if these are distinct projects.}, that are attempting to introduce lightweight thread\-ing in the form of Fibers. Both projects seem to be based on the \texttt{ForkJoinPool} in Java, which appears to be a simple incarnation of randomized work-stealing~\cite{MAN:java/fork-join}.
+Java has two projects, Quasar~\cite{MAN:quasar} and Project Loom~\cite{MAN:project-loom}\footnote{It is unclear if these are distinct projects.}, that are attempting to introduce lightweight thread\-ing in the form of Fibers.
+Both projects seem to be based on the \texttt{ForkJoinPool} in Java, which appears to be a simple incarnation of randomized work-stealing~\cite{MAN:java/fork-join}.
 
 \paragraph{Grand Central Dispatch}
-An Apple\cit{Official GCD source} API that offers task parallelism~\cite{wiki:taskparallel}. Its distinctive aspect is multiple ``Dispatch Queues'', some of which are created by programmers.  Each queue has its own local ordering guarantees, \eg \glspl{at} on queue $A$ are executed in \emph{FIFO} order.
+An Apple\cit{Official GCD source} API that offers task parallelism~\cite{wiki:taskparallel}.
+Its distinctive aspect is multiple ``Dispatch Queues'', some of which are created by programmers.
+Each queue has its own local ordering guarantees, \eg \ats on queue $A$ are executed in \emph{FIFO} order.
 
 \todo{load balancing and scheduling}
@@ -148 +204 @@
 % http://web.archive.org/web/20090920043909/http://images.apple.com/macosx/technology/docs/GrandCentral_TB_brief_20090903.pdf
 
-In terms of semantics, the Dispatch Queues seem to be very similar in semantics to Intel\textregistered ~TBB \texttt{execute()} and predecessor semantics. % Where it would be possible to convert from one to the other.
+In terms of semantics, the Dispatch Queues seem to be very similar to Intel\textregistered ~TBB \texttt{execute()} and predecessor semantics.
 
 \paragraph{LibFibre}
-LibFibre~\cite{DBLP:journals/pomacs/KarstenB20} is a light-weight user-level threading framework developed at the University of Waterloo. Similarly to Go, it uses a variation of work stealing with a global queue that is higher priority than stealing. Unlike Go, it does not have the high-priority next ``chair'' and does not use randomized work-stealing.
+LibFibre~\cite{DBLP:journals/pomacs/KarstenB20} is a light-weight user-level threading framework developed at the University of Waterloo.
+Similarly to Go, it uses a variation of work stealing with a global queue that is higher priority than stealing.
+Unlike Go, it does not have the high-priority next ``chair'' and does not use randomized work-stealing.

doc/theses/thierry_delisle_PhD/thesis/text/intro.tex

@@ -1 +1 @@
 \chapter{Introduction}\label{intro}
-\todo{A proper intro}
+\section{\CFA programming language}
 
-Any shared system needs scheduling.
-Computer systems share multiple resources across many threads of execution, even on single user computers like a laptop.
+The \CFA programming language~\cite{cfa:frontpage,cfa:typesystem} extends the C programming language by adding modern safety and productivity features, while maintaining backwards compatibility.
+Among its productivity features, \CFA supports user-level threading~\cite{Delisle21} allowing programmers to write modern concurrent and parallel programs.
+My previous master's thesis on concurrent in \CFA focused on features and interfaces.
+This Ph.D.\ thesis focuses on performance, introducing \glsxtrshort{api} changes only when required by performance considerations.
+Specifically, this work concentrates on scheduling and \glsxtrshort{io}.
+Prior to this work, the \CFA runtime used a strict \glsxtrshort{fifo} \gls{rQ} and no \glsxtrshort{io} capabilities at the user-thread level\footnote{C supports \glsxtrshort{io} capabilities at the kernel level, which means blocking operations block kernel threads where blocking user-level threads whould be more appropriate for \CFA.}.
+
+As a research project, this work builds exclusively on newer versions of the Linux operating-system and gcc/clang compilers.
+While \CFA is released, supporting older versions of Linux ($<$~Ubuntu 16.04) and gcc/clang compilers ($<$~gcc 6.0) is not a goal of this work.
+
+\section{Scheduling}
+Computer systems share multiple resources across many threads of execution, even on single user computers like laptops or smartphones.
+On a computer system with multiple processors and work units, there exists the problem of mapping work onto processors in an efficient manner, called \newterm{scheduling}.
+These systems are normally \newterm{open}, meaning new work arrives from an external source or is spawned from an existing work unit.
+On a computer system, the scheduler takes a sequence of work requests in the form of threads and attempts to complete the work, subject to performance objectives, such as resource utilization.
+A general-purpose dynamic-scheduler for an open system cannot anticipate future work requests, so its performance is rarely optimal.
+With complete knowledge of arrive order and work, creating an optimal solution still effectively needs solving the bin packing problem\cite{wiki:binpak}.
+However, optimal solutions are often not required.
+Schedulers do produce excellent solutions, whitout needing optimality, by taking advantage of regularities in work patterns.
+
 Scheduling occurs at discreet points when there are transitions in a system.
 For example, a thread cycles through the following transitions during its execution.
@@ -21 +39 @@
 \item
 normal completion or error, \ie segment fault (running $\rightarrow$ halted)
+\item
+scheduler assigns a thread to a resource (ready $\rightarrow$ running)
 \end{itemize}
 Key to scheduling is that a thread cannot bypass the ``ready'' state during a transition so the scheduler maintains complete control of the system.
 
-In detail, in a computer system with multiple processors and work units, there exists the problem of mapping work onto processors in an efficient manner, called \newterm{scheduling}.
-These systems are normally \newterm{open}, meaning new work arrives from an external source or spawned from an existing work unit.
-Scheduling is a zero-sum game as computer processors normally have a fixed, maximum number of cycles per unit time.
-(Frequency scaling and turbot boost add a degree of complexity that can be ignored in this discussion without loss of generality.)
-
-On a computer system, the scheduler takes a sequence of work requests in the form of threads and attempts to complete the work, subject to performance objectives, such as resource utilization.
-A general-purpose dynamic-scheduler for an open system cannot anticipate future work requests, so its performance is rarely optimal.
-Even with complete knowledge of arrive order and work, an optimal solution is NP (bin packing).
-However, schedulers do take advantage of regularities in work patterns to produce excellent solutions.
-Nevertheless, schedulers are a series of compromises, occasionally with some static or dynamic tuning parameters to enhance specific patterns.
-
 When the workload exceeds the capacity of the processors, \ie work cannot be executed immediately, it is placed on a queue for subsequent service, called a \newterm{ready queue}.
-(In real-life, a work unit (person) can \newterm{balk}, and leave the system rather than wait.)
 Ready queues organize threads for scheduling, which indirectly organizes the work to be performed.
-The structure of ready queues forms a spectrum.
-At one end is the single-queue multi-server (SIMS) and at the other end is the multi-queue multi-server (MOMS).
+The structure of ready queues can take many different forms.
+Where simple examples include single-queue multi-server (SQMS) and the multi-queue multi-server (MQMS).
 \begin{center}
 \begin{tabular}{l|l}
-\multicolumn{1}{c|}{\textbf{SIMS}} & \multicolumn{1}{c}{\textbf{MOMS}} \\
+\multicolumn{1}{c|}{\textbf{SQMS}} & \multicolumn{1}{c}{\textbf{MQMS}} \\
 \hline
 \raisebox{0.5\totalheight}{\input{SQMS.pstex_t}} & \input{MQMSG.pstex_t}
 \end{tabular}
 \end{center}
-(While \newterm{pipeline} organizations also exist, \ie chaining schedulers together, they do not provide an advantage in this context.)
+Beyond these two schedulers are a host of options, \ie adding an optional global, shared queue to MQMS.
 
 The three major optimization criteria for a scheduler are:
@@ -60 +68 @@
 
 \noindent
-Essentially, all multi-processor computers have non-uniform memory access (NUMB), with one or more quantized steps to access data at different levels (steps) in the memory hierarchy.
-When a system has a large number of independently executing threads, affinity is impossible because of \newterm{thread churn}.
+Essentially, all multi-processor computers have non-uniform memory access (NUMA), with one or more quantized steps to access data at different levels in the memory hierarchy.
+When a system has a large number of independently executing threads, affinity becomes difficult because of \newterm{thread churn}.
 That is, threads must be scheduled on multiple processors to obtain high processors utilization because the number of threads $\ggg$ processors.
 
 \item
-\newterm{contention}: safe access of shared objects by multiple processors requires mutual exclusion in the form of locking\footnote{
-Lock-free data-structures is still locking because all forms of locking invoke delays.}
+\newterm{contention}: safe access of shared objects by multiple processors requires mutual exclusion in some form, generally locking\footnote{
+Lock-free data-structures do not involve locking but incurr similar costs to achieve mutual exclusion.}
 
 \noindent
-Locking cost and latency increases significantly with the number of processors accessing a shared object.
+Mutual exclusion cost and latency increases significantly with the number of processors accessing a shared object.
 \end{enumerate}
 
-SIMS has perfect load-balancing but poor affinity and high contention by the processors, because of the single queue.
-MOMS has poor load-balancing but perfect affinity and no contention, because each processor has its own queue.
-Between these two schedulers are a host of options, \ie adding an optional global, shared ready-queue to MOMS.
+Nevertheless, schedulers are a series of compromises, occasionally with some static or dynamic tuning parameters to enhance specific patterns.
+Scheduling is a zero-sum game as computer processors normally have a fixed, maximum number of cycles per unit time\footnote{Frequency scaling and turbot boost add a degree of complexity that can be ignored in this discussion without loss of generality.}.
+SQMS has perfect load-balancing but poor affinity and high contention by the processors, because of the single queue.
+MQMS has poor load-balancing but perfect affinity and no contention, because each processor has its own queue.
+
 Significant research effort has also looked at load sharing/stealing among queues, when a ready queue is too long or short, respectively.
 These approaches attempt to perform better load-balancing at the cost of affinity and contention.
 Load sharing/stealing schedulers attempt to push/pull work units to/from other ready queues
 
-Note, a computer system is often lightly loaded (or has no load);
-any scheduler can handle this situation, \ie all schedulers are equal in this context.
-As the workload increases, there is a point where some schedulers begin to perform better than others based on the above criteria.
-A poorer scheduler might saturate for some reason and not be able to assign available work to idle processors, \ie processors are spinning when work is available.
+Note however that while any change comes at a cost, hence the zero-sum game, not all compromises are necessarily equivalent.
+Some schedulers can perform very well only in very specific workload scenarios, others might offer acceptable performance but be applicable to a wider range of workloads.
+Since \CFA attempts to improve the safety and productivity of C, the scheduler presented in this thesis attempts to achieve the same goals.
+More specifically, safety and productivity for scheduling means supporting a wide range of workloads so that programmers can rely on progress guarantees (safety) and more easily achieve acceptable performance (productivity).
 
 
-\section{\CFA programming language}
-
-\todo{Brief discussion on \CFA features used in the thesis.}
-
-The \CFA programming language~\cite{cfa:frontpage,cfa:typesystem} extends the C programming language by adding modern safety and productivity features, while maintaining backwards compatibility. Among its productivity features, \CFA supports user-level threading~\cite{Delisle21} allowing programmers to write modern concurrent and parallel programs.
-My previous master's thesis on concurrent in \CFA focused on features and interfaces.
-This Ph.D.\ thesis focuses on performance, introducing \glsxtrshort{api} changes only when required by performance considerations. Specifically, this work concentrates on scheduling and \glsxtrshort{io}. Prior to this work, the \CFA runtime used a strict \glsxtrshort{fifo} \gls{rQ} and  no non-blocking I/O capabilities at the user-thread level.
-
-As a research project, this work builds exclusively on newer versions of the Linux operating-system and gcc/clang compilers. While \CFA is released, supporting older versions of Linux ($<$~Ubuntu 16.04) and gcc/clang compilers ($<$~gcc 6.0) is not a goal of this work.
-
-
-\section{Contributions}
-\label{s:Contributions}
-
+\section{Contributions}\label{s:Contributions}
 This work provides the following contributions in the area of user-level scheduling in an advanced programming-language runtime-system:
 \begin{enumerate}[leftmargin=*]
 \item
-Guarantee no thread or set of threads can conspire to prevent other threads from executing.
-\begin{itemize}
+A scalable scheduling algorithm that offers progress guarantees.
 \item
-There must exist some form of preemption to prevent CPU-bound threads from gaining exclusive access to one or more processors.
+An algorithm for load-balancing and idle sleep of processors, including NUMA awareness.
 \item
-There must be a scheduler guarantee that threads are executed after CPU-bound threads are preempted.
-Otherwise, CPU-bound threads can immediately rescheduled, negating the preemption.
-\end{itemize}
-Hence, the runtime/scheduler provides a notion of fairness that is impossible for a programmer to violate.
-\item
-Provide comprehensive scheduling across all forms of preemption and blocking, where threads move from the running to ready or blocked states.
-
-Once a thread stops running, the processor executing it must be rescheduled, if possible.
-Knowing what threads are in the ready state for scheduling is difficult because blocking operations complete asynchronous and with poor notification.
-\item
-Efficiently deal with unbalanced workloads among processors.
-
-Simpler to 
-\item
-Efficiently deal with idle processors when there is less work than the available computing capacity.
+Support for user-level \glsxtrshort{io} capabilities based on Linux's \texttt{io\_uring}.
 \end{enumerate}

doc/theses/thierry_delisle_PhD/thesis/text/runtime.tex

@@ -4 +4 @@
 \section{C Threading}
 
-\Celeven introduced threading features, such the @_Thread_local@ storage class, and libraries @stdatomic.h@ and @threads.h@. Interestingly, almost a decade after the \Celeven standard, the most recent versions of gcc, clang, and msvc do not support the \Celeven include @threads.h@, indicating no interest in the C11 concurrency approach (possibly because of the recent effort to add concurrency to \CC). While the \Celeven standard does not state a threading model, the historical association with pthreads suggests implementations would adopt kernel-level threading (1:1)~\cite{ThreadModel}, as for \CC. This model uses \glspl{kthrd} to achieve parallelism and concurrency. In this model, every thread of computation maps to an object in the kernel. The kernel then has the responsibility of managing these threads, \eg creating, scheduling, blocking. A consequence of this approach is that the kernel has a perfect view of every thread executing in the system\footnote{This is not completely true due to primitives like \lstinline|futex|es, which have a significant portion of their logic in user space.}.
+\Celeven introduced threading features, such the @_Thread_local@ storage class, and libraries @stdatomic.h@ and @threads.h@.
+Interestingly, almost a decade after the \Celeven standard, the most recent versions of gcc, clang, and msvc do not support the \Celeven include @threads.h@, indicating no interest in the C11 concurrency approach (possibly because of the recent effort to add concurrency to \CC).
+While the \Celeven standard does not state a threading model, the historical association with pthreads suggests implementations would adopt kernel-level threading (1:1)~\cite{ThreadModel}, as for \CC.
+This model uses \glspl{kthrd} to achieve parallelism and concurrency. In this model, every thread of computation maps to an object in the kernel.
+The kernel then has the responsibility of managing these threads, \eg creating, scheduling, blocking.
+A consequence of this approach is that the kernel has a perfect view of every thread executing in the system\footnote{This is not completely true due to primitives like \lstinline|futex|es, which have a significant portion of their logic in user space.}.
 
 \section{M:N Threading}\label{prev:model}
@@ -10 +15 @@
 Threading in \CFA is based on \Gls{uthrding}, where \glspl{thrd} are the representation of a unit of work. As such, \CFA programmers should expect these units to be fairly inexpensive, \ie programmers should be able to create a large number of \glspl{thrd} and switch among \glspl{thrd} liberally without many concerns for performance.
 
-The \CFA M:N threading models is implemented using many user-level threads mapped onto fewer \glspl{kthrd}. The user-level threads have the same semantic meaning as a \glspl{kthrd} in the 1:1 model: they represent an independent thread of execution with its own stack. The difference is that user-level threads do not have a corresponding object in the kernel; they are handled by the runtime in user space and scheduled onto \glspl{kthrd}, referred to as \glspl{proc} in this document. \Glspl{proc} run a \gls{thrd} until it context switches out, it then chooses a different \gls{thrd} to run.
+The \CFA M:N threading models is implemented using many user-level threads mapped onto fewer \glspl{kthrd}.
+The user-level threads have the same semantic meaning as a \glspl{kthrd} in the 1:1 model: they represent an independent thread of execution with its own stack.
+The difference is that user-level threads do not have a corresponding object in the kernel; they are handled by the runtime in user space and scheduled onto \glspl{kthrd}, referred to as \glspl{proc} in this document. \Glspl{proc} run a \gls{thrd} until it context switches out, it then chooses a different \gls{thrd} to run.
 
 \section{Clusters}
-\CFA allows the option to group user-level threading, in the form of clusters. Both \glspl{thrd} and \glspl{proc} belong to a specific cluster. \Glspl{thrd} are only scheduled onto \glspl{proc} in the same cluster and scheduling is done independently of other clusters. Figure~\ref{fig:system} shows an overview of the \CFA runtime, which allows programmers to tightly control parallelism. It also opens the door to handling effects like NUMA, by pinning clusters to a specific NUMA node\footnote{This capability is not currently implemented in \CFA, but the only hurdle left is creating a generic interface for CPU masks.}.
+\CFA allows the option to group user-level threading, in the form of clusters.
+Both \glspl{thrd} and \glspl{proc} belong to a specific cluster.
+\Glspl{thrd} are only scheduled onto \glspl{proc} in the same cluster and scheduling is done independently of other clusters.
+Figure~\ref{fig:system} shows an overview of the \CFA runtime, which allows programmers to tightly control parallelism.
+It also opens the door to handling effects like NUMA, by pinning clusters to a specific NUMA node\footnote{This capability is not currently implemented in \CFA, but the only hurdle left is creating a generic interface for CPU masks.}.
 
 \begin{figure}
@@ -30 +41 @@
 
 \begin{quote}
-Given a simple network program with 2 \glspl{thrd} and a single \gls{proc}, one \gls{thrd} sends network requests to a server and the other \gls{thrd} waits for a response from the server. If the second \gls{thrd} races ahead, it may wait for responses to requests that have not been sent yet. In theory, this should not be a problem, even if the second \gls{thrd} waits, because the first \gls{thrd} is still ready to run and should be able to get CPU time to send the request. With M:N threading, while the first \gls{thrd} is ready, the lone \gls{proc} \emph{cannot} run the first \gls{thrd} if it is blocked in the \glsxtrshort{io} operation of the second \gls{thrd}. If this happen, the system is in a synchronization deadlock\footnote{In this example, the deadlock could be resolved if the server sends unprompted messages to the client. However, this solution is neither general nor appropriate even in this simple case.}.
+Given a simple network program with 2 \glspl{thrd} and a single \gls{proc}, one \gls{thrd} sends network requests to a server and the other \gls{thrd} waits for a response from the server.
+If the second \gls{thrd} races ahead, it may wait for responses to requests that have not been sent yet.
+In theory, this should not be a problem, even if the second \gls{thrd} waits, because the first \gls{thrd} is still ready to run and should be able to get CPU time to send the request.
+With M:N threading, while the first \gls{thrd} is ready, the lone \gls{proc} \emph{cannot} run the first \gls{thrd} if it is blocked in the \glsxtrshort{io} operation of the second \gls{thrd}.
+If this happen, the system is in a synchronization deadlock\footnote{In this example, the deadlock could be resolved if the server sends unprompted messages to the client.
+However, this solution is neither general nor appropriate even in this simple case.}.
 \end{quote}
 
-Therefore, one of the objective of this work is to introduce \emph{User-Level \glsxtrshort{io}}, which like \glslink{uthrding}{User-Level \emph{Threading}}, blocks \glspl{thrd} rather than \glspl{proc} when doing \glsxtrshort{io} operations. This feature entails multiplexing the \glsxtrshort{io} operations of many \glspl{thrd} onto fewer \glspl{proc}. The multiplexing requires a single \gls{proc} to execute multiple \glsxtrshort{io} operations in parallel. This requirement cannot be done with operations that block \glspl{proc}, \ie \glspl{kthrd}, since the first operation would prevent starting new operations for its blocking duration. Executing \glsxtrshort{io} operations in parallel requires \emph{asynchronous} \glsxtrshort{io}, sometimes referred to as \emph{non-blocking}, since the \gls{kthrd} does not block.
+Therefore, one of the objective of this work is to introduce \emph{User-Level \glsxtrshort{io}}, which like \glslink{uthrding}{User-Level \emph{Threading}}, blocks \glspl{thrd} rather than \glspl{proc} when doing \glsxtrshort{io} ope      rations.
+This feature entails multiplexing the \glsxtrshort{io} operations of many \glspl{thrd} onto fewer \glspl{proc}.
+The multiplexing requires a single \gls{proc} to execute multiple \glsxtrshort{io} operations in parallel.
+This requirement cannot be done with operations that block \glspl{proc}, \ie \glspl{kthrd}, since the first operation would prevent starting new operations for its blocking duration.
+Executing \glsxtrshort{io} operations in parallel requires \emph{asynchronous} \glsxtrshort{io}, sometimes referred to as \emph{non-blocking}, since the \gls{kthrd} does not block.
 
 \section{Interoperating with C}
@@ -49 +69 @@
         \item Introducing safe-point code (see Go~page~\pageref{GoSafePoint}) can have a significant impact on general performance.
 \end{enumerate}
-Because of these consequences, this work does not attempt to ``sandbox'' calls to C. Therefore, it is possible calls to an unknown library function can block a \gls{kthrd} leading to deadlocks in \CFA's M:N threading model, which would not occur in a traditional 1:1 threading model. Currently, all M:N thread systems interacting with UNIX without sandboxing suffer from this problem but manage to work very well in the majority of applications. Therefore, a complete solution to this problem is outside the scope of this thesis.\footnote{\CFA does provide a pthreads emulation, so any library function using embedded pthreads locks are redirected to \CFA user-level locks. This capability further reduces the chances of blocking a \gls{kthrd}.}
+Because of these consequences, this work does not attempt to ``sandbox'' calls to C.
+Therefore, it is possible calls to an unknown library function can block a \gls{kthrd} leading to deadlocks in \CFA's M:N threading model, which would not occur in a traditional 1:1 threading model.
+Currently, all M:N thread systems interacting with UNIX without sandboxing suffer from this problem but manage to work very well in the majority of applications.
+Therefore, a complete solution to this problem is outside the scope of this thesis.\footnote{\CFA does provide a pthreads emulation, so any library function using embedded pthreads locks are redirected to \CFA user-level locks. This capability further reduces the chances of blocking a \gls{kthrd}.}

libcfa/src/concurrency/locks.hfa

@@ -533 +533 @@
         #endif
         lock( lock, node );
-        while(held) Pause();
-        held = true;
+        while(__atomic_load_n(&held, __ATOMIC_SEQ_CST)) Pause();
+        __atomic_store_n(&held, true, __ATOMIC_SEQ_CST);
         unlock( lock, node );
         #ifdef __CFA_DEBUG__
@@ -545 +545 @@
         owner = 0p;
         #endif
-        held = false;
+        __atomic_store_n(&held, false, __ATOMIC_SEQ_CST);
 }
 
@@ -586 +586 @@
         #endif
         lock( lock );
-        while(held) Pause();
-        held = true;
+        while(__atomic_load_n(&held, __ATOMIC_SEQ_CST)) Pause();
+        __atomic_store_n(&held, true, __ATOMIC_RELEASE);
         unlock( lock );
         #ifdef __CFA_DEBUG__
@@ -598 +598 @@
         owner = 0p;
         #endif
-        held = false;
+        __atomic_store_n(&held, false, __ATOMIC_RELEASE);
 }
 

src/AST/Decl.hpp

@@ -316 +316 @@
         EnumDecl( const CodeLocation& loc, const std::string& name,
                 std::vector<ptr<Attribute>>&& attrs = {}, Linkage::Spec linkage = Linkage::Cforall, Type * base = nullptr,
-                 std::unordered_map< std::string, long long > enumValues = std::unordered_map< std::string, long long >() )
+                std::unordered_map< std::string, long long > enumValues = std::unordered_map< std::string, long long >() )
         : AggregateDecl( loc, name, std::move(attrs), linkage ), base(base), enumValues(enumValues) {}
 

src/AST/Inspect.cpp

@@ -5 +5 @@
 // file "LICENCE" distributed with Cforall.
 //
-// Node.hpp --
+// Inspect.cpp -- Helpers to get information from the AST.
 //
 // Author           : Thierry Delisle
 // Created On       : Fri Jun 24 13:16:31 2022
-// Last Modified By :
-// Last Modified On :
-// Update Count     :
+// Last Modified By : Andrew Beach
+// Last Modified On : Mon Jun 27 15:35:00 2022
+// Update Count     : 1
 //
 
@@ -21 +21 @@
 
 namespace ast {
-        bool structHasFlexibleArray( const ast::StructDecl * decl ) {
-                if(decl->members.size() == 0) return false;
-                const auto & last = *decl->members.rbegin();
-                auto lastd = last.as<ast::DeclWithType>();
-                if(!lastd) return false; // I don't know what this is possible, but it might be.
-                auto atype = dynamic_cast<const ast::ArrayType *>(lastd->get_type());
-                if(!atype) return false;
-                return !atype->isVarLen && !atype->dimension;
-        }
-};
+
+bool structHasFlexibleArray( const ast::StructDecl * decl ) {
+        if(decl->members.size() == 0) return false;
+        const auto & last = *decl->members.rbegin();
+        auto lastd = last.as<ast::DeclWithType>();
+        // I don't know what this is possible, but it might be.
+        if(!lastd) return false;
+        auto atype = dynamic_cast<const ast::ArrayType *>(lastd->get_type());
+        if(!atype) return false;
+        return !atype->isVarLen && !atype->dimension;
+}
+
+} // namespace ast

src/AST/Inspect.hpp

@@ -5 +5 @@
 // file "LICENCE" distributed with Cforall.
 //
-// Node.hpp --
+// Inspect.hpp -- Helpers to get information from the AST.
 //
 // Author           : Thierry Delisle
 // Created On       : Fri Jun 24 13:16:31 2022
-// Last Modified By :
-// Last Modified On :
-// Update Count     :
+// Last Modified By : Andrew Beach
+// Last Modified On : Mon Jun 27 15:35:00 2022
+// Update Count     : 1
 //
 
@@ -17 +17 @@
 
 namespace ast {
-        bool structHasFlexibleArray( const ast::StructDecl * );
+
+// Does the structure end in a flexable array declaration?
+bool structHasFlexibleArray( const ast::StructDecl * );
+
 }

src/SymTab/Validate.cc

@@ -312 +312 @@
                         Stats::Heap::newPass("validate-B");
                         Stats::Time::BlockGuard guard("validate-B");
-                        //linkReferenceToTypes( translationUnit );
+                        linkReferenceToTypes( translationUnit ); // Must happen before auto-gen, because it uses the sized flag.
                         mutateAll( translationUnit, fixQual ); // must happen after LinkReferenceToTypes_old, because aggregate members are accessed
                         HoistStruct::hoistStruct( translationUnit );

src/Validate/module.mk

@@ -41 +41 @@
         Validate/LabelAddressFixer.cpp \
         Validate/LabelAddressFixer.hpp \
+        Validate/LinkReferenceToTypes.cpp \
+        Validate/LinkReferenceToTypes.hpp \
         Validate/NoIdSymbolTable.hpp \
         Validate/ReturnCheck.cpp \

src/main.cc

@@ -85 +85 @@
 #include "Validate/InitializerLength.hpp"   // for setLengthFromInitializer
 #include "Validate/LabelAddressFixer.hpp"   // for fixLabelAddresses
+#include "Validate/LinkReferenceToTypes.hpp" // for linkReferenceToTypes
 #include "Validate/ReturnCheck.hpp"         // for checkReturnStatements
 #include "Virtual/ExpandCasts.h"            // for expandCasts
@@ -333 +334 @@
                 PASS( "Validate-A", SymTab::validate_A( translationUnit ) );
 
-                // Must happen before auto-gen, because it uses the sized flag.
-                PASS( "Link Reference To Types", SymTab::linkReferenceToTypes( translationUnit ) );
-
                 CodeTools::fillLocations( translationUnit );
 
@@ -348 +346 @@
 
                         forceFillCodeLocations( transUnit );
+
+                        // Must happen before auto-gen, because it uses the sized flag.
+                        PASS( "Link Reference To Types", Validate::linkReferenceToTypes( transUnit ) );
 
                         // Must happen after Link References To Types,

tests/enum_tests/structEnum.cfa

@@ -24 +24 @@
 int main() {
     printf("%d %c\n", apple.x, apple.y);
-    // Failed; enumInstType is now not a real type and not instantiated. 
+    // Failed; enumInstType is now not a real type and not instantiated.
     // Not sure if we want that
     // printf("%d %c\n", second.x, second.y);
     return 0;
 }
-
-
-