Changeset 0690350 for src/SynTree

Timestamp:

Jan 12, 2018, 4:57:40 PM (6 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

1a4bef3

Parents:

bd0b6b62

git-author:

Rob Schluntz <rschlunt@…> (01/12/18 15:24:25)

git-committer:

Rob Schluntz <rschlunt@…> (01/12/18 16:57:40)

Message:

Minor code cleanup

Location:

src/SynTree

Files:

• AggregateDecl.cc (modified) (1 diff)
• Expression.cc (modified) (2 diffs)

src/SynTree/AggregateDecl.cc

@@ -92 +92 @@
                 } else if ( ConstantExpr * constExpr = dynamic_cast< ConstantExpr * >( expr ) ) {
                         return constExpr->intValue();
+                // can be -1, +1, etc.
+                // } else if ( UntypedExpr * untypedExpr = dynamic_cast< UntypedExpr * >( expr ) ) {
+                //      if ( untypedExpr-> )
                 } else {
                         assertf( false, "Unhandled expression type in getConstValue for enumerators: %s", toString( expr ).c_str() );

src/SynTree/Expression.cc

@@ -108 +108 @@
         //      assert( inst->baseEnum );
         //      EnumDecl * decl = inst->baseEnum;
-        //      for ( Declaration * member : decl->members ) {
-        //              if ( member == _var ) {
-        //                      type->set_lvalue( false );
-        //              }
+        //      long long int value;
+        //      if ( decl->valueOf( var, value ) ) {
+        //              type->set_lvalue( false );
         //      }
         // }
@@ -416 +415 @@
                 } else {
                         // references have been removed, in which case dereference returns an lvalue of the base type.
-                        ret->get_result()->set_lvalue( true );
+                        ret->result->set_lvalue( true );
                 }
         }