Changeset 05e6eb5

Timestamp:

Jul 30, 2018, 4:43:48 PM (6 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, no_list, persistent-indexer, pthread-emulation, qualifiedEnum

Children:

5cbacf1

Parents:

fd2debf

git-author:

Rob Schluntz <rschlunt@…> (07/30/18 15:38:10)

git-committer:

Rob Schluntz <rschlunt@…> (07/30/18 16:43:48)

Message:

Warn about constructor/destructor priorities 101-200 only when not building the library

Location:

src

Files:

• CompilationState.cc (modified) (1 diff)
• CompilationState.h (modified) (1 diff)
• Validate/HandleAttributes.cc (modified) (2 diffs)
• main.cc (modified) (3 diffs)

src/CompilationState.cc

@@ -39 +39 @@
         linemarks = false;
 
-// bootstrapping:
-//   libcfap || treep
-
 // Local Variables: //
 // tab-width: 4 //

src/CompilationState.h

@@ -40 +40 @@
         linemarks;
 
-
+// is the compiler building prelude or libcfa?
+inline bool buildingLibrary() {
+        return libcfap | treep;
+}
 
 // Local Variables: //

src/Validate/HandleAttributes.cc

@@ -117 +117 @@
                                 std::string name = attr->normalizedName();
                                 if (name == "init_priority") {
-
+                                        // TODO: implement C++-like init_priority attribute
                                 }
                         }
@@ -139 +139 @@
                                                         SemanticWarning(attr->location, Warning::GccAttributes,
                                                                 toCString( name, " priorities from 0 to 100 are reserved for the implementation" ) );
-                                                } else if (priority < 201) {
+                                                } else if (priority < 201 && ! buildingLibrary()) {
                                                         SemanticWarning(attr->location, Warning::GccAttributes,
                                                                 toCString( name, " priorities from 101 to 200 are reserved for the implementation" ) );

src/main.cc

@@ -183 +183 @@
 
                         // Read to gcc builtins, if not generating the cfa library
-                        FILE * gcc_builtins = fopen( libcfap | treep ? "../prelude/gcc-builtins.cf" : CFA_LIBDIR "/gcc-builtins.cf", "r" );
+                        FILE * gcc_builtins = fopen( buildingLibrary() ? "../prelude/gcc-builtins.cf" : CFA_LIBDIR "/gcc-builtins.cf", "r" );
                         assertf( gcc_builtins, "cannot open gcc-builtins.cf\n" );
                         parse( gcc_builtins, LinkageSpec::Compiler );
 
                         // read the extra prelude in, if not generating the cfa library
-                        FILE * extras = fopen( libcfap | treep ? "../prelude/extras.cf" : CFA_LIBDIR "/extras.cf", "r" );
+                        FILE * extras = fopen( buildingLibrary() ? "../prelude/extras.cf" : CFA_LIBDIR "/extras.cf", "r" );
                         assertf( extras, "cannot open extras.cf\n" );
                         parse( extras, LinkageSpec::BuiltinC );
@@ -194 +194 @@
                         if ( ! libcfap ) {
                                 // read the prelude in, if not generating the cfa library
-                                FILE * prelude = fopen( treep ? "../prelude/prelude.cf" : CFA_LIBDIR "/prelude.cf", "r" );
+                                FILE * prelude = fopen( buildingLibrary() ? "../prelude/prelude.cf" : CFA_LIBDIR "/prelude.cf", "r" );
                                 assertf( prelude, "cannot open prelude.cf\n" );
                                 parse( prelude, LinkageSpec::Intrinsic );
 
                                 // Read to cfa builtins, if not generating the cfa library
-                                FILE * builtins = fopen( libcfap | treep ? "../prelude/builtins.cf" : CFA_LIBDIR "/builtins.cf", "r" );
+                                FILE * builtins = fopen( buildingLibrary() ? "../prelude/builtins.cf" : CFA_LIBDIR "/builtins.cf", "r" );
                                 assertf( builtins, "cannot open builtins.cf\n" );
                                 parse( builtins, LinkageSpec::BuiltinCFA );
@@ -274 +274 @@
 
                 // fix ObjectDecl - replaces ConstructorInit nodes
-                PASS( "fixInit", InitTweak::fix( translationUnit, libcfap || treep ) );
+                PASS( "fixInit", InitTweak::fix( translationUnit, buildingLibrary() ) );
                 if ( ctorinitp ) {
                         dump ( translationUnit );