Changeset 03b812d2

Timestamp:

Aug 22, 2016, 3:31:47 PM (8 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, ctor, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, memory, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

bd9f8be

Parents:

8d2844a

Message:

delete UntypedExpr? arguments and fix missing clones

Location:

src

Files:

• CodeGen/CodeGenerator.cc (modified) (1 diff)
• InitTweak/FixInit.cc (modified) (1 diff)
• SynTree/Expression.cc (modified) (1 diff)

src/CodeGen/CodeGenerator.cc

@@ -311 +311 @@
                                                         Type * type = InitTweak::getPointerBase( (*arg)->get_results().front() );
                                                         assert( type );
-                                                        newExpr->get_results().push_back( type );
+                                                        newExpr->get_results().push_back( type->clone() );
                                                         *arg = newExpr;
                                                 } // if

src/InitTweak/FixInit.cc

@@ -284 +284 @@
                         UntypedExpr * untyped = new UntypedExpr( new NameExpr( fname ) );
                         untyped->get_args().push_back( new AddressExpr( new VariableExpr( var ) ) );
-                        if (cpArg) untyped->get_args().push_back( cpArg );
+                        if (cpArg) untyped->get_args().push_back( cpArg->clone() );
 
                         // resolve copy constructor

src/SynTree/Expression.cc

@@ -385 +385 @@
 UntypedExpr::~UntypedExpr() {
         delete function;
-        // deleteAll( args );  //TODO FIXME the arguments are leaked but they seem to be shared in some way
+        deleteAll( args );
 }