Changeset 0335620

Timestamp:

May 7, 2020, 5:12:47 PM (4 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

dd4e2d7

Parents:

5dadc9b

Message:

Some minor tweaking to increase performance

Files:

• benchmark/io/readv.cfa (modified) (3 diffs)
• libcfa/src/concurrency/io.cfa (modified) (3 diffs)

benchmark/io/readv.cfa

@@ -64 +64 @@
         for(;;) {
                 static struct option options[] = {
-                        {"duration",   required_argument, 0, 'd'},
-                        {"nthreads",   required_argument, 0, 't'},
-                        {"nprocs",     required_argument, 0, 'p'},
-                        {"bufsize",    required_argument, 0, 'b'},
-                        {"userthread", no_argument      , 0, 'u'},
+                        {"duration",     required_argument, 0, 'd'},
+                        {"nthreads",     required_argument, 0, 't'},
+                        {"nprocs",       required_argument, 0, 'p'},
+                        {"bufsize",      required_argument, 0, 'b'},
+                        {"userthread",   no_argument      , 0, 'u'},
+                        {"submitthread", no_argument      , 0, 's'},
                         {0, 0, 0, 0}
                 };
 
                 int idx = 0;
-                int opt = getopt_long(argc, argv, "d:t:p:b:u", options, &idx);
+                int opt = getopt_long(argc, argv, "d:t:p:b:us", options, &idx);
 
                 const char * arg = optarg ? optarg : "";
@@ -113 +114 @@
                                 flags |= CFA_CLUSTER_IO_POLLER_USER_THREAD;
                                 break;
+                        case 's':
+                                flags |= CFA_CLUSTER_IO_POLLER_THREAD_SUBMITS;
+                                break;
                         // Other cases
                         default: /* ? */
@@ -123 +127 @@
                                 fprintf(stderr, "  -p, --nprocs=NPROCS      Number of kernel threads\n");
                                 fprintf(stderr, "  -b, --buflen=SIZE        Number of bytes to read per request\n");
+                                fprintf(stderr, "  -u, --userthread         If set, cluster uses user-thread to poll I/O\n");
+                                fprintf(stderr, "  -s, --submitthread       If set, cluster uses polling thread to submit I/O\n");
                                 exit(EXIT_FAILURE);
                 }

libcfa/src/concurrency/io.cfa

@@ -280 +280 @@
 
                 if( io_flags & CFA_CLUSTER_IO_POLLER_THREAD_SUBMITS ) {
-                        sq.ready_cnt = 10;
-                        sq.ready = alloc( sq.ready_cnt );
+                        sq.ready_cnt = 32;
+                        sq.ready = alloc_align( 64, sq.ready_cnt );
                         for(i; sq.ready_cnt) {
                                 sq.ready[i] = -1ul32;
@@ -584 +584 @@
                                 int count;
                                 bool again;
-                                [count, again] = __drain_io( ring, &mask, 1, true );
+                                [count, again] = __drain_io( ring, &mask, 0, true );
 
                                 // Update statistics
@@ -665 +665 @@
         }
 
+        static inline void __wake_poller( struct __io_data & ring ) __attribute__((artificial));
         static inline void __wake_poller( struct __io_data & ring ) {
-                sigval val = { 1 };
-                pthread_sigqueue( ring.poller.slow.kthrd, SIGUSR1, val );
+                // sigval val = { 1 };
+                // pthread_sigqueue( ring.poller.slow.kthrd, SIGUSR1, val );
         }