Changeset 027c496 for src/Tuples

Timestamp:

Dec 1, 2017, 10:35:50 AM (6 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

2449aef

Parents:

c5f3c68

git-author:

Rob Schluntz <rschlunt@…> (12/01/17 10:35:42)

git-committer:

Rob Schluntz <rschlunt@…> (12/01/17 10:35:50)

Message:

Convert ImpurityDetector? to PassVisitor?

File:

• src/Tuples/TupleExpansion.cc (modified) (3 diffs)

src/Tuples/TupleExpansion.cc

@@ -315 +315 @@
         namespace {
                 /// determines if impurity (read: side-effects) may exist in a piece of code. Currently gives a very crude approximation, wherein any function call expression means the code may be impure
-                class ImpurityDetector : public Visitor {
-                public:
+                struct ImpurityDetector : public WithShortCircuiting {
                         ImpurityDetector( bool ignoreUnique ) : ignoreUnique( ignoreUnique ) {}
 
-                        typedef Visitor Parent;
-                        virtual void visit( ApplicationExpr * appExpr ) {
+                        void previsit( ApplicationExpr * appExpr ) {
+                                visit_children = false;
                                 if ( DeclarationWithType * function = InitTweak::getFunction( appExpr ) ) {
                                         if ( function->get_linkage() == LinkageSpec::Intrinsic ) {
                                                 if ( function->get_name() == "*?" || function->get_name() == "?[?]" ) {
                                                         // intrinsic dereference, subscript are pure, but need to recursively look for impurity
-                                                        Parent::visit( appExpr );
+                                                        visit_children = true;
                                                         return;
                                                 }
@@ -332 +331 @@
                                 maybeImpure = true;
                         }
-                        virtual void visit( UntypedExpr * ) { maybeImpure = true; }
-                        virtual void visit( UniqueExpr * unq ) {
+                        void previsit( UntypedExpr * ) { maybeImpure = true; visit_children = false; }
+                        void previsit( UniqueExpr * ) {
                                 if ( ignoreUnique ) {
                                         // bottom out at unique expression.
                                         // The existence of a unique expression doesn't change the purity of an expression.
                                         // That is, even if the wrapped expression is impure, the wrapper protects the rest of the expression.
+                                        visit_children = false;
                                         return;
                                 }
-                                maybeAccept( unq->expr, *this );
                         }
 
@@ -349 +348 @@
 
         bool maybeImpure( Expression * expr ) {
-                ImpurityDetector detector( false );
+                PassVisitor<ImpurityDetector> detector( false );
                 expr->accept( detector );
-                return detector.maybeImpure;
+                return detector.pass.maybeImpure;
         }
 
         bool maybeImpureIgnoreUnique( Expression * expr ) {
-                ImpurityDetector detector( true );
+                PassVisitor<ImpurityDetector> detector( true );
                 expr->accept( detector );
-                return detector.maybeImpure;
+                return detector.pass.maybeImpure;
         }
 } // namespace Tuples