Changeset d3ab183 for libcfa/src/concurrency/alarm.cfa

Timestamp:

May 4, 2020, 8:59:09 PM (4 years ago)

Author:

Michael Brooks <mlbrooks@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

08a994e, f90d10f

Parents:

4d741e9

Message:

Using dlist in alarm.

Minimal interface changes in alarm.hfa applied; some spill to preemption.cfa occured.

List management logic removed, including such helper functions from alarm.cfa. Remaining logic is concurrency-protection wrapping, and picking insertion point by traversing and comparing alarm-fire times.

Integrity checking definitions removed here. Calling version brought into list.hfa by change 4d741 instead.

File:

• libcfa/src/concurrency/alarm.cfa (modified) (6 diffs)

libcfa/src/concurrency/alarm.cfa

@@ -51 +51 @@
         this.alarm = alarm;
         this.period = period;
-        next = 0;
         set = false;
         kernel_alarm = false;
@@ -60 +59 @@
         this.alarm = alarm;
         this.period = period;
-        next = 0;
         set = false;
         kernel_alarm = true;
@@ -71 +69 @@
 }
 
-#if !defined(NDEBUG) && (defined(__CFA_DEBUG__) || defined(__CFA_VERIFY__))
-bool validate( alarm_list_t * this ) {
-        alarm_node_t ** it = &this->head;
-        while( (*it) ) {
-                it = &(*it)->next;
+void insert( alarm_list_t * this, alarm_node_t * n ) {
+        alarm_node_t * it = & (*this)`first;
+        while( it && (n->alarm > it->alarm) ) {
+                it = & (*it)`next;
+        }
+        if ( it ) {
+                insert_before( *it, *n );
+        } else {
+                insert_last(*this, *n);
         }
 
-        return it == this->tail;
-}
-#endif
-
-static inline void insert_at( alarm_list_t * this, alarm_node_t * n, __alarm_it_t p ) {
-        verify( !n->next );
-        if( p == this->tail ) {
-                this->tail = &n->next;
-        }
-        else {
-                n->next = *p;
-        }
-        *p = n;
-
-        verify( validate( this ) );
-}
-
-void insert( alarm_list_t * this, alarm_node_t * n ) {
-        alarm_node_t ** it = &this->head;
-        while( (*it) && (n->alarm > (*it)->alarm) ) {
-                it = &(*it)->next;
-        }
-
-        insert_at( this, n, it );
-
-        verify( validate( this ) );
+        verify( validate( *this ) );
 }
 
 alarm_node_t * pop( alarm_list_t * this ) {
-        alarm_node_t * head = this->head;
+        verify( validate( *this ) );
+        alarm_node_t * head = & (*this)`first;
         if( head ) {
-                this->head = head->next;
-                if( !head->next ) {
-                        this->tail = &this->head;
-                }
-                head->next = 0p;
+                remove(*head);
         }
-        verify( validate( this ) );
+        verify( validate( *this ) );
         return head;
 }
 
-static inline void remove_at( alarm_list_t * this, alarm_node_t * n, __alarm_it_t it ) {
-        verify( it );
-        verify( (*it) == n );
-
-        (*it) = n->next;
-        if( !n-> next ) {
-                this->tail = it;
-        }
-        n->next = 0p;
-
-        verify( validate( this ) );
-}
-
-static inline void remove( alarm_list_t * this, alarm_node_t * n ) {
-        alarm_node_t ** it = &this->head;
-        while( (*it) && (*it) != n ) {
-                it = &(*it)->next;
-        }
-
-        verify( validate( this ) );
-
-        if( *it ) { remove_at( this, n, it ); }
-
-        verify( validate( this ) );
-}
-
 void register_self( alarm_node_t * this ) {
-        alarm_list_t * alarms = &event_kernel->alarms;
+        alarm_list_t & alarms = event_kernel->alarms;
 
         disable_interrupts();
@@ -152 +100 @@
         {
                 verify( validate( alarms ) );
-                bool first = !alarms->head;
+                bool first = ! & alarms`first;
 
-                insert( alarms, this );
+                insert( &alarms, this );
                 if( first ) {
-                        __kernel_set_timer( alarms->head->alarm - __kernel_get_time() );
+                        __kernel_set_timer( alarms`first.alarm - __kernel_get_time() );
                 }
         }
@@ -168 +116 @@
         lock( event_kernel->lock __cfaabi_dbg_ctx2 );
         {
-                verify( validate( &event_kernel->alarms ) );
-                remove( &event_kernel->alarms, this );
+                verify( validate( event_kernel->alarms ) );
+                remove( *this );
         }
         unlock( event_kernel->lock );
@@ -187 +135 @@
 
         /* paranoid */ verify( !node.set );
-        /* paranoid */ verify( node.next == 0p );
+        /* paranoid */ verify( & node`next == 0p );
+        /* paranoid */ verify( & node`prev == 0p );
 }