Changeset c0453ca3 for src/SymTab/Mangler.cc

Timestamp:

Apr 30, 2018, 11:07:21 AM (6 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, with_gc

Children:

1a3eab8

Parents:

1da22500

Message:

Remove reference type mangling to prevent reference and non-reference overloading

File:

• src/SymTab/Mangler.cc (modified) (6 diffs)

src/SymTab/Mangler.cc

@@ -35 +35 @@
                 namespace {
                         /// Mangles names to a unique C identifier
-                        struct Mangler : public WithShortCircuiting, public WithVisitorRef<Mangler> {
+                        struct Mangler : public WithShortCircuiting, public WithVisitorRef<Mangler>, public WithGuards {
                                 Mangler( bool mangleOverridable, bool typeMode, bool mangleGenericParams );
                                 Mangler( const Mangler & ) = delete;
@@ -70 +70 @@
                                 bool typeMode;                  ///< Produce a unique mangled name for a type
                                 bool mangleGenericParams;       ///< Include generic parameters in name mangling if true
+                                bool inFunctionType = false;    ///< Include type qualifiers if false.
 
                                 void mangleDecl( DeclarationWithType *declaration );
@@ -189 +190 @@
 
                         void Mangler::postvisit( ReferenceType * refType ) {
+                                // don't print prefix (e.g. 'R') for reference types so that references and non-references do not overload.
+                                // Further, do not print the qualifiers for a reference type (but do run printQualifers because of TypeDecls, etc.),
+                                // by pretending every reference type is a function parameter.
+                                GuardValue( inFunctionType );
+                                inFunctionType = true;
                                 printQualifiers( refType );
-                                mangleName << "R";
                                 maybeAccept( refType->base, *visitor );
                         }
@@ -206 +211 @@
                                 printQualifiers( functionType );
                                 mangleName << "F";
+                                // turn on inFunctionType so that printQualifiers does not print most qualifiers for function parameters,
+                                // since qualifiers on outermost parameter type do not differentiate function types, e.g.,
+                                // void (*)(const int) and void (*)(int) are the same type, but void (*)(const int *) and void (*)(int *) are different
+                                GuardValue( inFunctionType );
+                                inFunctionType = true;
                                 std::list< Type* > returnTypes = getTypes( functionType->get_returnVals() );
                                 acceptAll( returnTypes, *visitor );
@@ -304 +314 @@
                                 // skip if not including qualifiers
                                 if ( typeMode ) return;
-
                                 if ( ! type->get_forall().empty() ) {
                                         std::list< std::string > assertionNames;
@@ -337 +346 @@
                                         mangleName << "_";
                                 } // if
-                                if ( type->get_const() ) {
-                                        mangleName << "C";
-                                } // if
-                                if ( type->get_volatile() ) {
-                                        mangleName << "V";
-                                } // if
+                                if ( ! inFunctionType ) {
+                                        // these qualifiers do not distinguish the outermost type of a function parameter
+                                        if ( type->get_const() ) {
+                                                mangleName << "C";
+                                        } // if
+                                        if ( type->get_volatile() ) {
+                                                mangleName << "V";
+                                        } // if
+                                        // Removed due to restrict not affecting function compatibility in GCC
+                                        // if ( type->get_isRestrict() ) {
+                                        //      mangleName << "E";
+                                        // } // if
+                                        if ( type->get_atomic() ) {
+                                                mangleName << "A";
+                                        } // if
+                                }
                                 if ( type->get_mutex() ) {
                                         mangleName << "M";
                                 } // if
-                                // Removed due to restrict not affecting function compatibility in GCC
-                //              if ( type->get_isRestrict() ) {
-                //                      mangleName << "E";
-                //              } // if
                                 if ( type->get_lvalue() ) {
                                         // mangle based on whether the type is lvalue, so that the resolver can differentiate lvalues and rvalues
                                         mangleName << "L";
                                 }
-                                if ( type->get_atomic() ) {
-                                        mangleName << "A";
-                                } // if
+
+                                if ( inFunctionType ) {
+                                        // turn off inFunctionType so that types can be differentiated for nested qualifiers
+                                        GuardValue( inFunctionType );
+                                        inFunctionType = false;
+                                }
                         }
                 }       // namespace