Changeset bbbc067 for src/ResolvExpr/Resolver.cc

Timestamp:

Jan 29, 2019, 4:30:46 PM (5 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

no_list

Children:

8d25360

Parents:

bee0694

Message:

Changed std::list<Initializer> to vector

File:

• src/ResolvExpr/Resolver.cc (modified) (8 diffs)

src/ResolvExpr/Resolver.cc

@@ -80 +80 @@
                 void previsit( ConstructorInit *ctorInit );
           private:
-                typedef std::list< Initializer * >::iterator InitIterator;
+                typedef std::vector< Initializer * >::iterator InitIterator;
 
                 template< typename PtrType >
@@ -235 +235 @@
                                 winner.cost = winner.cvtCost;
                         }
-                        
+
                         // produce ambiguous errors, if applicable
                         if ( winners.size() != 1 ) {
@@ -255 +255 @@
 
                         // xxx - check for ambiguous expressions
-                        
+
                         // output selected choice
                         alt = std::move( choice );
@@ -402 +402 @@
 
         void Resolver::previsit( ObjectDecl *objectDecl ) {
-                // To handle initialization of routine pointers, e.g., int (*fp)(int) = foo(), means that 
-                // class-variable initContext is changed multiple time because the LHS is analysed twice. 
-                // The second analysis changes initContext because of a function type can contain object 
-                // declarations in the return and parameter types. So each value of initContext is 
+                // To handle initialization of routine pointers, e.g., int (*fp)(int) = foo(), means that
+                // class-variable initContext is changed multiple time because the LHS is analysed twice.
+                // The second analysis changes initContext because of a function type can contain object
+                // declarations in the return and parameter types. So each value of initContext is
                 // retained, so the type on the first analysis is preserved and used for selecting the RHS.
                 GuardValue( currentObject );
@@ -442 +442 @@
 
         void Resolver::postvisit( FunctionDecl *functionDecl ) {
-                // default value expressions have an environment which shouldn't be there and trips up 
+                // default value expressions have an environment which shouldn't be there and trips up
                 // later passes.
-                // xxx - it might be necessary to somehow keep the information from this environment, but I 
+                // xxx - it might be necessary to somehow keep the information from this environment, but I
                 // can't currently see how it's useful.
                 for ( Declaration * d : functionDecl->type->parameters ) {
@@ -795 +795 @@
                 initExpr->expr = nullptr;
                 std::swap( initExpr->env, newExpr->env );
-                // InitExpr may have inferParams in the case where the expression specializes a function 
-                // pointer, and newExpr may already have inferParams of its own, so a simple swap is not 
+                // InitExpr may have inferParams in the case where the expression specializes a function
+                // pointer, and newExpr may already have inferParams of its own, so a simple swap is not
                 // sufficient.
                 newExpr->spliceInferParams( initExpr );
                 delete initExpr;
 
-                // get the actual object's type (may not exactly match what comes back from the resolver 
+                // get the actual object's type (may not exactly match what comes back from the resolver
                 // due to conversions)
                 Type * initContext = currentObject.getCurrentType();
@@ -814 +814 @@
                                         if ( isCharType( pt->get_base() ) ) {
                                                 if ( CastExpr *ce = dynamic_cast< CastExpr * >( newExpr ) ) {
-                                                        // strip cast if we're initializing a char[] with a char *, 
+                                                        // strip cast if we're initializing a char[] with a char *,
                                                         // e.g.  char x[] = "hello";
                                                         newExpr = ce->get_arg();
@@ -837 +837 @@
                 // move cursor into brace-enclosed initializer-list
                 currentObject.enterListInit();
-                // xxx - fix this so that the list isn't copied, iterator should be used to change current 
+                // xxx - fix this so that the list isn't copied, iterator should be used to change current
                 // element
                 std::list<Designation *> newDesignations;
                 for ( auto p : group_iterate(listInit->get_designations(), listInit->get_initializers()) ) {
-                        // iterate designations and initializers in pairs, moving the cursor to the current 
+                        // iterate designations and initializers in pairs, moving the cursor to the current
                         // designated object and resolving the initializer against that object.
                         Designation * des = std::get<0>(p);