Changeset b94579a for libcfa/src/concurrency/locks.cfa

Timestamp:

Nov 7, 2025, 8:30:59 AM (5 days ago)

Author:

Peter A. Buhr <pabuhr@…>

Branches:

master

Parents:

0048327

Message:

update semaphore lock

File:

• libcfa/src/concurrency/locks.cfa (modified) (5 diffs)

libcfa/src/concurrency/locks.cfa

@@ -587 +587 @@
 // Semaphore, counting
 
-// PRIVATE
-
-thread$ * V( semaphore & sem, const bool doUnpark ) with( sem ) {
-        thread$ * thrd = 0p;
-        lock( lock$ __cfaabi_dbg_ctx2 );
-        count$ += 1;
-        if ( count$ <= 0 ) {
-                thrd = pop_head( waiting$ );                                            // remove task at head of waiting list
-        }
-        unlock( lock$ );
-        if ( doUnpark ) unpark( thrd );                                         // make new owner
-        return thrd;
-}
-
-// PUBLIC
-
 void ?{}( semaphore & sem, ssize_t count = 1 ) with( sem ) {
         count$ = count;
@@ -613 +597 @@
         count$ -= 1;
         if ( count$ < 0 ) {                                                                     // in use ?
-                append( waiting$, active_thread() );                            // queue current task
-                unlock( lock$ );                                                                        // atomically release spin lock and block
+                append( waiting$, active_thread() );                    // queue current task
+                unlock( lock$ );                                                                // atomically release spin lock and block
                 park();
                 return false;
@@ -629 +613 @@
                 } // if
         } else {
-                V( sem );                                                                               // V other semaphore
+                V( lock );                                                                              // V mutex semaphore
                 count$ -= 1;
         } // if
@@ -654 +638 @@
 }
 
-bool V( semaphore & sem ) with( sem ) {
+thread$ * V( semaphore & sem, const bool doUnpark ) with( sem ) {
         thread$ * thrd = 0p;
         lock( lock$ __cfaabi_dbg_ctx2 );
@@ -662 +646 @@
         }
         unlock( lock$ );
-        if ( true ) unpark( thrd );                                             // make new owner
-//      thread$ * thrd = V(sem, true);
-        return thrd != 0p;
+        if ( doUnpark ) unpark( thrd );                                         // make new owner
+        return thrd;
 }