Changeset b7c53a9d for src/AST/Util.cpp

Timestamp:

Jul 14, 2023, 9:32:31 AM (15 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

402a1e7

Parents:

4acf56d

Message:

Added a new invariant check and the fixes required to make it pass. Not the new check is by no means exaustive (it doesn't even check every readonly pointer) but it should catch the most common/problematic cases.

File:

• src/AST/Util.cpp (modified) (2 diffs)

src/AST/Util.cpp

@@ -102 +102 @@
 }
 
+/// Check for Floating Nodes:
+/// Every node should be reachable from a root (the TranslationUnit) via a
+/// chain of structural references (tracked with ptr). This cannot check all
+/// of that, it just checks if a given node's field has a strong reference.
+template<typename node_t, typename field_t>
+void noFloatingNode( const node_t * node, field_t node_t::*field_ptr ) {
+        const field_t & field = node->*field_ptr;
+        if ( nullptr == field ) return;
+        assertf( field->isManaged(), "Floating node found." );
+}
+
 struct InvariantCore {
         // To save on the number of visits: this is a kind of composed core.
@@ -127 +138 @@
         }
 
+        void previsit( const VariableExpr * node ) {
+                previsit( (const ParseNode *)node );
+                noFloatingNode( node, &VariableExpr::var );
+        }
+
         void previsit( const MemberExpr * node ) {
                 previsit( (const ParseNode *)node );
                 memberMatchesAggregate( node );
+        }
+
+        void previsit( const StructInstType * node ) {
+                previsit( (const Node *)node );
+                noFloatingNode( node, &StructInstType::base );
+        }
+
+        void previsit( const UnionInstType * node ) {
+                previsit( (const Node *)node );
+                noFloatingNode( node, &UnionInstType::base );
+        }
+
+        void previsit( const EnumInstType * node ) {
+                previsit( (const Node *)node );
+                noFloatingNode( node, &EnumInstType::base );
+        }
+
+        void previsit( const TypeInstType * node ) {
+                previsit( (const Node *)node );
+                noFloatingNode( node, &TypeInstType::base );
         }