Changeset a300e4a for src/AST/porting.md

Timestamp:

May 9, 2019, 5:17:51 PM (4 years ago)

Author:

Aaron Moss <a3moss@…>

Branches:

arm-eh, cleanup-dtors, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

3e46cc8

Parents:

2bb4a01

Message:

Add some decls to the new AST

File:

• src/AST/porting.md (modified) (2 diffs)

src/AST/porting.md

@@ -55 +55 @@
 * Preserve names from previous AST whenever reasonable, and get team consensus on any changes.
 * Strong justification required for private fields
-  * No `get_` prefix on getters
+  * No `get_` prefix on getters (including for generated fields)
 * Notable changes:
   * for concision and consistency with subclasses:
@@ -81 +81 @@
 `DeclWithType`
 * When `SymTab::Validate::Pass2` is rewritten, update comment on `mangleName` with new name of pass
+* `get_scopedMangleName()` => `scopedMangleName()`
+* `get_type()` => `type()`
+  * now returns `const Type*` so can't be inadvertently mutated
+
+`EnumDecl`
+* **TODO** rebuild `eval` for new AST (re: `valueOf` implementation)
 
 `Expr`