Changeset 64a7146 for libcfa/src/concurrency/ready_queue.cfa

Timestamp:

Jun 19, 2020, 3:49:43 PM (4 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

68f36f4

Parents:

04b5cef

Message:

Fixed idle sleep to no-longer use a spinlock, broke registration and gdbtools in the process

File:

• libcfa/src/concurrency/ready_queue.cfa (modified) (6 diffs)

libcfa/src/concurrency/ready_queue.cfa

@@ -81 +81 @@
         this.handle = proc;
         this.lock   = false;
+        #ifdef __CFA_WITH_VERIFY__
+                this.owned  = false;
+        #endif
 }
 
@@ -97 +100 @@
                         && __atomic_compare_exchange_n( &data[i].handle, &null, proc, false, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST)) {
                         /*paranoid*/ verify(i < ready);
-                        /*paranoid*/ verify(__alignof__(data[i]) == cache_line_size);
+                        /*paranoid*/ verify(0 == (__alignof__(data[i]) % cache_line_size));
                         /*paranoid*/ verify((((uintptr_t)&data[i]) % cache_line_size) == 0);
                         return i;
@@ -562 +565 @@
 
 //-----------------------------------------------------------------------
+__attribute__((hot)) bool query(struct cluster * cltr) {
+        return query(cltr->ready_queue.snzi);
+}
+
+//-----------------------------------------------------------------------
 __attribute__((hot)) bool push(struct cluster * cltr, struct $thread * thrd) with (cltr->ready_queue) {
         __cfadbg_print_safe(ready_queue, "Kernel : Pushing %p on cluster %p\n", thrd, cltr);
@@ -761 +769 @@
 // Grow the ready queue
 void ready_queue_grow  (struct cluster * cltr) {
-        // Lock the RWlock so no-one pushes/pops while we are changing the queue
-        uint_fast32_t last_size = ready_mutate_lock();
-
+        /* paranoid */ verify( ready_mutate_islocked() );
         __cfadbg_print_safe(ready_queue, "Kernel : Growing ready queue\n");
 
@@ -808 +814 @@
         __cfadbg_print_safe(ready_queue, "Kernel : Growing ready queue done\n");
 
-        // Unlock the RWlock
-        ready_mutate_unlock( last_size );
+        /* paranoid */ verify( ready_mutate_islocked() );
 }
 
 // Shrink the ready queue
 void ready_queue_shrink(struct cluster * cltr) {
-        // Lock the RWlock so no-one pushes/pops while we are changing the queue
-        uint_fast32_t last_size = ready_mutate_lock();
-
+        /* paranoid */ verify( ready_mutate_islocked() );
         __cfadbg_print_safe(ready_queue, "Kernel : Shrinking ready queue\n");
 
@@ -889 +892 @@
 
         __cfadbg_print_safe(ready_queue, "Kernel : Shrinking ready queue done\n");
-
-        // Unlock the RWlock
-        ready_mutate_unlock( last_size );
-}
+        /* paranoid */ verify( ready_mutate_islocked() );
+}