Changeset 5bf1f3e for tests/pybin/settings.py

Timestamp:

Mar 26, 2019, 10:36:58 AM (6 years ago)

Author:

tdelisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, cleanup-dtors, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

1bb2488

Parents:

eb60b04

Message:

Code review of test.py and pybin

File:

• tests/pybin/settings.py (modified) (5 diffs)

tests/pybin/settings.py

@@ -37 +37 @@
         def __init__(self, arch):
                 try:
-                        canonical_host = Architecture.makeCanonical( config.HOSTARCH )
+                        canonical_host = Architecture.make_canonical( config.HOSTARCH )
                 except KeyError:
                         print("Unkown host architecture %s" % config.HOSTARCH, file=sys.stderr)
@@ -44 +44 @@
                 if arch:
                         try:
-                                arch = Architecture.makeCanonical( arch )
+                                arch = Architecture.make_canonical( arch )
                         except KeyError:
                                 print("Unkown architecture %s" % arch, file=sys.stderr)
@@ -75 +75 @@
 
         @classmethod
-        def makeCanonical(_, arch):
+        def make_canonical(_, arch):
                 return Architecture.KnownArchitectures[arch]
 
@@ -110 +110 @@
         global install
         global timeout
-        global width
+        global output_width
 
-        dry_run    = options.dry_run
-        generating = options.regenerate_expected
-        make       = 'make'
-        debug        = Debug(options.debug)
-        install    = Install(options.install)
-        arch       = Architecture(options.arch)
-        timeout    = Timeouts(options.timeout, options.global_timeout)
-        width      = 24
+        dry_run      = options.dry_run
+        generating   = options.regenerate_expected
+        make         = 'make'
+        debug        = Debug(options.debug)
+        install      = Install(options.install)
+        arch         = Architecture(options.arch)
+        timeout      = Timeouts(options.timeout, options.global_timeout)
+        output_width = 24
 
 
-def updateMakeCmd(force, jobs):
+def update_make_cmd(force, jobs):
         global make
 
@@ -141 +141 @@
 
 def prep_output(tests):
-        global width
-        width = max(map(lambda t: len(t.target()), tests))
+        global output_width
+        output_width = max(map(lambda t: len(t.target()), tests))