Changeset 54c9000 for src/SynTree/Attribute.cc

Timestamp:

Feb 13, 2018, 11:12:25 AM (6 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

490ff5c3

Parents:

7a052e34

git-author:

Rob Schluntz <rschlunt@…> (02/12/18 16:21:06)

git-committer:

Rob Schluntz <rschlunt@…> (02/13/18 11:12:25)

Message:

Fix missing attribute warning

File:

• src/SynTree/Attribute.cc (modified) (2 diffs)

src/SynTree/Attribute.cc

@@ -15 +15 @@
 
 #include <ostream>           // for operator<<, ostream, basic_ostream, endl
+#include <set>
 
 #include "Attribute.h"
@@ -21 +22 @@
 
 Attribute::Attribute( const Attribute &other ) : name( other.name ) {
-  cloneAll( other.parameters, parameters );
+        cloneAll( other.parameters, parameters );
 }
 
 Attribute::~Attribute() {
-  deleteAll( parameters );
+        deleteAll( parameters );
+}
+
+bool Attribute::isValidOnFuncParam() const {
+        // attributes such as aligned, cleanup, etc. produce GCC errors when they appear
+        // on function parameters. Maintain here a whitelist of attribute names that are
+        // allowed to appear on parameters.
+        static std::set< std::string > valid = {
+                "noreturn", "unused"
+        };
+        return valid.count( normalizedName() );
+}
+
+std::string Attribute::normalizedName() const {
+        // trim beginning/ending _, convert to lowercase
+        auto begin = name.find_first_not_of('_');
+        auto end = name.find_last_not_of('_');
+        if (begin == std::string::npos || end == std::string::npos) return "";
+        std::string ret;
+        ret.reserve( end-begin+1 );
+        std::transform( &name[begin], &name[end+1], back_inserter( ret ), tolower );
+        return ret;
 }
 
 void Attribute::print( std::ostream &os, Indenter indent ) const {
-  using std::endl;
-  using std::string;
+        using std::endl;
+        using std::string;
 
-  if ( ! empty() ) {
-    os << "Attribute with name: " << name;
-    if ( ! parameters.empty() ) {
-      os << " with parameters: " << endl;
-      printAll( parameters, os, indent+1 );
-    }
-  }
+        if ( ! empty() ) {
+                os << "Attribute with name: " << name;
+                if ( ! parameters.empty() ) {
+                        os << " with parameters: " << endl;
+                        printAll( parameters, os, indent+1 );
+                }
+        }
 }