Changeset 4f762d3 for benchmark/io/http/options.cfa

Timestamp:

Feb 19, 2021, 1:48:14 PM (2 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

arm-eh, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

d60d30e

Parents:

78da4ab

Message:

Fix httpforall after changes to I/O

File:

• benchmark/io/http/options.cfa (modified) (3 diffs)

benchmark/io/http/options.cfa

@@ -46 +46 @@
 
 void parse_options( int argc, char * argv[] ) {
-        bool subthrd = false;
-        bool eagrsub = false;
-        bool fixedfd = false;
-        bool sqkpoll = false;
-        bool iokpoll = false;
-        unsigned sublen = 16;
+        // bool fixedfd = false;
+        // bool sqkpoll = false;
+        // bool iokpoll = false;
         unsigned nentries = 16;
 
@@ -65 +62 @@
                 {'\0', "cache-size",     "Size of the cache to use, if set to small, will uses closes power of 2", options.file_cache.size },
                 {'\0', "list-files",     "List the files in the specified path and exit", options.file_cache.list, parse_settrue },
-                { 's', "submitthread",   "If set, cluster uses polling thread to submit I/O", subthrd, parse_settrue },
-                { 'e', "eagersubmit",    "If set, cluster submits I/O eagerly but still aggregates submits", eagrsub, parse_settrue},
-                { 'f', "fixed-fds",      "If set, files are open eagerly and pre-registered with the cluster", fixedfd, parse_settrue},
-                { 'k', "kpollsubmit",    "If set, cluster uses IORING_SETUP_SQPOLL, implies -f", sqkpoll, parse_settrue },
-                { 'i', "kpollcomplete",  "If set, cluster uses IORING_SETUP_IOPOLL", iokpoll, parse_settrue },
-                {'\0', "submitlength",   "Max number of submitions that can be submitted together", sublen },
+                // { 'f', "fixed-fds",      "If set, files are open eagerly and pre-registered with the cluster", fixedfd, parse_settrue},
+                // { 'k', "kpollsubmit",    "If set, cluster uses IORING_SETUP_SQPOLL, implies -f", sqkpoll, parse_settrue },
+                // { 'i', "kpollcomplete",  "If set, cluster uses IORING_SETUP_IOPOLL", iokpoll, parse_settrue },
                 {'\0', "numentries",     "Number of I/O entries", nentries },
 
@@ -93 +87 @@
         options.clopts.params.num_entries = nentries;
 
-        options.clopts.params.poller_submits = subthrd;
-        options.clopts.params.eager_submits  = eagrsub;
+        // if( fixedfd ) {
+        //      options.file_cache.fixed_fds = true;
+        // }
 
-        if( fixedfd ) {
-                options.file_cache.fixed_fds = true;
-        }
+        // if( sqkpoll ) {
+        //      options.file_cache.fixed_fds = true;
+        // }
 
-        if( sqkpoll ) {
-                options.clopts.params.poll_submit = true;
-                options.file_cache.fixed_fds = true;
-        }
-
-        if( iokpoll ) {
-                options.clopts.params.poll_complete = true;
-                options.file_cache.open_flags |= O_DIRECT;
-        }
-
-        options.clopts.params.num_ready = sublen;
+        // if( iokpoll ) {
+        //      options.file_cache.open_flags |= O_DIRECT;
+        // }
 
         if( left[0] == 0p ) { return; }