Changeset 35285fd for libcfa/src/concurrency/io.cfa

Timestamp:

Jan 12, 2021, 1:10:41 PM (16 months ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

arm-eh, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast-unique-expr

Children:

481ee28

Parents:

d48b174

Message:

Refactor sqe reclamation to systematically thrash the sqe in debug

File:

• libcfa/src/concurrency/io.cfa (modified) (2 diffs)

libcfa/src/concurrency/io.cfa

@@ -195 +195 @@
         static unsigned __collect_submitions( struct __io_data & ring );
         static __u32 __release_consumed_submission( struct __io_data & ring );
+        static inline void __clean( volatile struct io_uring_sqe * sqe );
 
         // Process a single completion message from the io_uring
@@ -746 +747 @@
 
                         /* paranoid */ verify( 0 != ring.submit_q.sqes[ idx ].user_data );
-                        ring.submit_q.sqes[ idx ].user_data = 3ul64;
+                        __clean( &ring.submit_q.sqes[ idx ] );
                 }
                 return count;
         }
+
+        void __sqe_clean( volatile struct io_uring_sqe * sqe ) {
+                __clean( sqe );
+        }
+
+        static inline void __clean( volatile struct io_uring_sqe * sqe ) {
+                // If we are in debug mode, thrash the fields to make sure we catch reclamation errors
+                __cfaabi_dbg_debug_do(
+                        memset(sqe, 0xde, sizeof(*sqe));
+                        sqe->opcode = IORING_OP_LAST;
+                );
+
+                // Mark the entry as unused
+                __atomic_store_n(&sqe->user_data, 3ul64, __ATOMIC_SEQ_CST);
+        }
 #endif