Changeset 321a2481 for src/CodeGen/CodeGenerator.cc

Timestamp:

Jun 6, 2016, 1:11:34 PM (6 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

aaron-thesis, arm-eh, cleanup-dtors, ctor, deferred_resn, demangler, enum, forall-pointer-decay, gc_noraii, jacob/cs343-translation, jenkins-sandbox, master, memory, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, resolv-new, with_gc

Children:

64071c2

Parents:

b8387fc

git-author:

Rob Schluntz <rschlunt@…> (06/06/16 13:08:28)

git-committer:

Rob Schluntz <rschlunt@…> (06/06/16 13:11:34)

Message:

add void casts to code generator to reduce gcc warnings

File:

• src/CodeGen/CodeGenerator.cc (modified) (3 diffs)

src/CodeGen/CodeGenerator.cc

@@ -638 +638 @@
 
         void CodeGenerator::visit( ExprStmt *exprStmt ) {
-                // I don't see why this check is necessary.
-                // If this starts to cause problems then put it back in,
-                // with an explanation
                 assert( exprStmt );
-
-                // if ( exprStmt != 0 ) {
-                exprStmt->get_expr()->accept( *this );
-                output << ";" ;
-                // } // if
+                // cast the top-level expression to void to reduce gcc warnings.
+                Expression * expr = new CastExpr( exprStmt->get_expr() );
+                expr->accept( *this );
+                output << ";";
         }
 
@@ -755 +751 @@
 
         void CodeGenerator::visit( WhileStmt *whileStmt ) {
-                if ( whileStmt->get_isDoWhile() )
+                if ( whileStmt->get_isDoWhile() ) {
                         output << "do" ;
-                else {
+                } else {
                         output << "while (" ;
                         whileStmt->get_condition()->accept( *this );
@@ -781 +777 @@
                 output << "for (;";
 
-                if ( forStmt->get_condition() != 0 )
+                if ( forStmt->get_condition() != 0 ) {
                         forStmt->get_condition()->accept( *this );
+                }
                 output << ";";
 
-                if ( forStmt->get_increment() != 0 )
-                        forStmt->get_increment()->accept( *this );
+                if ( forStmt->get_increment() != 0 ) {
+                        // cast the top-level expression to void to reduce gcc warnings.
+                        Expression * expr = new CastExpr( forStmt->get_increment() );
+                        expr->accept( *this );
+                }
                 output << ") ";