Changeset 1e940de0 for libcfa/src/virtual_dtor.hfa

Timestamp:

Jun 14, 2023, 4:44:00 PM (23 months ago)

Author:

caparsons <caparson@…>

Branches:

master

Children:

8d6786b

Parents:

7e4bd9b6

Message:

cleanup/bugfix actors and fix virtual dtor bug

File:

• libcfa/src/virtual_dtor.hfa (modified) (1 diff)

libcfa/src/virtual_dtor.hfa

@@ -25 +25 @@
     __virtual_obj_start = &this;
 }
-static inline void __CFA_dtor_shutdown( virtual_dtor & this ) with(this) {
+static inline bool __CFA_dtor_shutdown( virtual_dtor & this ) with(this) {
+    if ( __virtual_dtor_ptr == 1p ) return true; // stop base dtors from being called twice
     if ( __virtual_dtor_ptr ) {
         void (*dtor_ptr)(virtual_dtor &) = __virtual_dtor_ptr;
         __virtual_dtor_ptr = 0p;
-        dtor_ptr(*((virtual_dtor *)__virtual_obj_start)); // replace actor with base type
-        return;
+        dtor_ptr(*((virtual_dtor *)__virtual_obj_start)); // call most derived dtor
+        __virtual_dtor_ptr = 1p; // stop base dtors from being called twice
+        return true;
     }
+    return false;
 }
 static inline void __CFA_virt_free( virtual_dtor & this ) { free( this.__virtual_obj_start ); }