Changeset 00ac42e for src/ResolvExpr/ConversionCost.cc

Timestamp:

Jun 1, 2018, 2:54:55 PM (7 years ago)

Author:

Aaron Moss <a3moss@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, with_gc

Children:

262bd63

Parents:

41e16b1

git-author:

Aaron Moss <a3moss@…> (05/31/18 16:24:49)

git-committer:

Aaron Moss <a3moss@…> (06/01/18 14:54:55)

Message:

stop eagerly copying EqvClass? on lookup

File:

• src/ResolvExpr/ConversionCost.cc (modified) (2 diffs)

src/ResolvExpr/ConversionCost.cc

@@ -42 +42 @@
         Cost conversionCost( Type *src, Type *dest, const SymTab::Indexer &indexer, const TypeEnvironment &env ) {
                 if ( TypeInstType *destAsTypeInst = dynamic_cast< TypeInstType* >( dest ) ) {
-                        EqvClass eqvClass;
-                        NamedTypeDecl *namedType;
                         PRINT( std::cerr << "type inst " << destAsTypeInst->name; )
-                        if ( env.lookup( destAsTypeInst->name, eqvClass ) ) {
-                                if ( eqvClass.type ) {
-                                        return conversionCost( src, eqvClass.type, indexer, env );
+                        if ( const EqvClass* eqvClass = env.lookup( destAsTypeInst->name ) ) {
+                                if ( eqvClass->type ) {
+                                        return conversionCost( src, eqvClass->type, indexer, env );
                                 } else {
                                         return Cost::infinity;
                                 }
-                        } else if ( ( namedType = indexer.lookupType( destAsTypeInst->name ) ) ) {
+                        } else if ( NamedTypeDecl *namedType = indexer.lookupType( destAsTypeInst->name ) ) {
                                 PRINT( std::cerr << " found" << std::endl; )
                                 TypeDecl *type = dynamic_cast< TypeDecl* >( namedType );
@@ -369 +367 @@
 
         void ConversionCost::postvisit( TypeInstType *inst ) {
-                EqvClass eqvClass;
-                NamedTypeDecl *namedType;
-                if ( env.lookup( inst->name, eqvClass ) ) {
-                        cost = costFunc( eqvClass.type, dest, indexer, env );
+                if ( const EqvClass *eqvClass = env.lookup( inst->name ) ) {
+                        cost = costFunc( eqvClass->type, dest, indexer, env );
                 } else if ( TypeInstType *destAsInst = dynamic_cast< TypeInstType* >( dest ) ) {
                         if ( inst->name == destAsInst->name ) {
                                 cost = Cost::zero;
                         }
-                } else if ( ( namedType = indexer.lookupType( inst->name ) ) ) {
+                } else if ( NamedTypeDecl *namedType = indexer.lookupType( inst->name ) ) {
                         TypeDecl *type = dynamic_cast< TypeDecl* >( namedType );
                         // all typedefs should be gone by this point